Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599413 > unrolled thread

[PATCH] kasan: Add a prototype of task_struct to avoid warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] kasan: Add a prototype of task_struct to avoid warning Arnd Bergmann <arnd@arndb.de> - 2017-03-13 15:20 +0100
    Re: [PATCH] kasan: Add a prototype of task_struct to avoid warning Alexander Potapenko <glider@google.com> - 2017-03-13 15:30 +0100

#1599413 — [PATCH] kasan: Add a prototype of task_struct to avoid warning

From: Masami Hiramatsu <mhiramat@kernel.org>

Add a prototype of task_struct to fix below warning on arm64.

In file included from arch/arm64/kernel/probes/kprobes.c:19:0:
include/linux/kasan.h:81:132: error: 'struct task_struct' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
 static inline void kasan_unpoison_task_stack(struct task_struct *task) {}

As same as other types (kmem_cache, page, and vm_struct) this adds a
prototype of task_struct data structure on top of kasan.h.

[arnd] A related warning was fixed before, but now appears in a different
line in the same file in v4.11-rc2. The patch from Masami Hiramatsu
still seems appropriate, so let's take his version.

Link: https://patchwork.kernel.org/patch/9569839/
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/kasan.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/kasan.h b/include/linux/kasan.h
index 1c823bef4c15..5734480c9590 100644
--- a/include/linux/kasan.h
+++ b/include/linux/kasan.h
@@ -6,6 +6,7 @@
 struct kmem_cache;
 struct page;
 struct vm_struct;
+struct task_struct;
 
 #ifdef CONFIG_KASAN
 
-- 
2.9.0

[toc] | [next] | [standalone]

#1599444

On Mon, Mar 13, 2017 at 3:14 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> From: Masami Hiramatsu <mhiramat@kernel.org>
>
> Add a prototype of task_struct to fix below warning on arm64.
>
> In file included from arch/arm64/kernel/probes/kprobes.c:19:0:
> include/linux/kasan.h:81:132: error: 'struct task_struct' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>  static inline void kasan_unpoison_task_stack(struct task_struct *task) {}
>
> As same as other types (kmem_cache, page, and vm_struct) this adds a
> prototype of task_struct data structure on top of kasan.h.
>
> [arnd] A related warning was fixed before, but now appears in a different
> line in the same file in v4.11-rc2. The patch from Masami Hiramatsu
> still seems appropriate, so let's take his version.
>
> Link: https://patchwork.kernel.org/patch/9569839/
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Alexander Potapenko <glider@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexander Potapenko <glider@google.com>
> ---
>  include/linux/kasan.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 1c823bef4c15..5734480c9590 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -6,6 +6,7 @@
>  struct kmem_cache;
>  struct page;
>  struct vm_struct;
> +struct task_struct;
>
>  #ifdef CONFIG_KASAN
>
> --
> 2.9.0
>



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web