Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596417 > unrolled thread
| Started by | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| First post | 2017-03-09 23:20 +0100 |
| Last post | 2017-03-13 15:00 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/8] i2c: export i2c_client_type structure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-09 23:20 +0100
Re: [PATCH 1/8] i2c: export i2c_client_type structure Wolfram Sang <wsa@the-dreams.de> - 2017-03-10 00:20 +0100
Re: [PATCH 1/8] i2c: export i2c_client_type structure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-10 00:50 +0100
Re: [PATCH 1/8] i2c: export i2c_client_type structure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-10 01:00 +0100
Re: [PATCH 1/8] i2c: export i2c_client_type structure Jean Delvare <jdelvare@suse.de> - 2017-03-13 15:00 +0100
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-03-09 23:20 +0100 |
| Subject | [PATCH 1/8] i2c: export i2c_client_type structure |
| Message-ID | <tjezE-2W7-15@gated-at.bofh.it> |
i2c bus has 2 different types of device belonging to the same bus and
bus notifiers use device type to distinguish between adapters and clients.
Previously we only had i2c_adapter_type exported, which made code wanting
to work with i2c_client devices test for type not equal to adapter type.
This unfortunately is not safe if we ever add another type to the bus,
so let's export i2c_client_type as well.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Wolfram, this is the patch I was talking about in the other mail.
drivers/i2c/i2c-core.c | 4 ++--
include/linux/i2c.h | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 34a5115484dd..446e341e9508 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -74,7 +74,6 @@
static DEFINE_MUTEX(core_lock);
static DEFINE_IDR(i2c_adapter_idr);
-static struct device_type i2c_client_type;
static int i2c_detect(struct i2c_adapter *adapter, struct i2c_driver *driver);
static struct static_key i2c_trace_msg = STATIC_KEY_INIT_FALSE;
@@ -1096,11 +1095,12 @@ struct bus_type i2c_bus_type = {
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
-static struct device_type i2c_client_type = {
+struct device_type i2c_client_type = {
.groups = i2c_dev_groups,
.uevent = i2c_device_uevent,
.release = i2c_client_dev_release,
};
+EXPORT_SYMBOL_GPL(i2c_client_type);
/**
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 2cc3988d127b..89ca5e56b433 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -37,6 +37,7 @@
extern struct bus_type i2c_bus_type;
extern struct device_type i2c_adapter_type;
+extern struct device_type i2c_client_type;
/* --- General options ------------------------------------------------ */
--
2.12.0.246.ga2ecc84866-goog
[toc] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-03-10 00:20 +0100 |
| Message-ID | <tjfvH-3x7-11@gated-at.bofh.it> |
| In reply to | #1596417 |
[Multipart message — attachments visible in raw view] — view raw
Dmitry,
On Thu, Mar 09, 2017 at 02:16:37PM -0800, Dmitry Torokhov wrote:
> i2c bus has 2 different types of device belonging to the same bus and
> bus notifiers use device type to distinguish between adapters and clients.
> Previously we only had i2c_adapter_type exported, which made code wanting
> to work with i2c_client devices test for type not equal to adapter type.
> This unfortunately is not safe if we ever add another type to the bus,
> so let's export i2c_client_type as well.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> Wolfram, this is the patch I was talking about in the other mail.
I see. From a glimpse, I am fine with the patch. I'll add Jean Delvare
to CC, though, in case I missed some detail he still knows. Furthermore,
while I agree that testing for "not adapter" when one means "is client"
is not nice, is there a bigger benefit than being correct in your queue?
Regards,
Wolfram
>
> drivers/i2c/i2c-core.c | 4 ++--
> include/linux/i2c.h | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index 34a5115484dd..446e341e9508 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -74,7 +74,6 @@
> static DEFINE_MUTEX(core_lock);
> static DEFINE_IDR(i2c_adapter_idr);
>
> -static struct device_type i2c_client_type;
> static int i2c_detect(struct i2c_adapter *adapter, struct i2c_driver *driver);
>
> static struct static_key i2c_trace_msg = STATIC_KEY_INIT_FALSE;
> @@ -1096,11 +1095,12 @@ struct bus_type i2c_bus_type = {
> };
> EXPORT_SYMBOL_GPL(i2c_bus_type);
>
> -static struct device_type i2c_client_type = {
> +struct device_type i2c_client_type = {
> .groups = i2c_dev_groups,
> .uevent = i2c_device_uevent,
> .release = i2c_client_dev_release,
> };
> +EXPORT_SYMBOL_GPL(i2c_client_type);
>
>
> /**
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 2cc3988d127b..89ca5e56b433 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -37,6 +37,7 @@
>
> extern struct bus_type i2c_bus_type;
> extern struct device_type i2c_adapter_type;
> +extern struct device_type i2c_client_type;
>
> /* --- General options ------------------------------------------------ */
>
> --
> 2.12.0.246.ga2ecc84866-goog
>
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-03-10 00:50 +0100 |
| Message-ID | <tjfYJ-3JY-1@gated-at.bofh.it> |
| In reply to | #1596465 |
On Fri, Mar 10, 2017 at 12:12:46AM +0100, Wolfram Sang wrote: > Dmitry, > > On Thu, Mar 09, 2017 at 02:16:37PM -0800, Dmitry Torokhov wrote: > > i2c bus has 2 different types of device belonging to the same bus and > > bus notifiers use device type to distinguish between adapters and clients. > > Previously we only had i2c_adapter_type exported, which made code wanting > > to work with i2c_client devices test for type not equal to adapter type. > > This unfortunately is not safe if we ever add another type to the bus, > > so let's export i2c_client_type as well. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > --- > > > > Wolfram, this is the patch I was talking about in the other mail. > > I see. From a glimpse, I am fine with the patch. I'll add Jean Delvare > to CC, though, in case I missed some detail he still knows. Furthermore, > while I agree that testing for "not adapter" when one means "is client" > is not nice, is there a bigger benefit than being correct in your queue? No, just my dislike of testing for "dev->type != &i2c_adapter_type" in the new i2c bus notifier when we want to work with i2c clients. Thanks. -- Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-03-10 01:00 +0100 |
| Message-ID | <tjg8q-3Nj-3@gated-at.bofh.it> |
| In reply to | #1596485 |
On Thu, Mar 09, 2017 at 03:46:24PM -0800, Dmitry Torokhov wrote: > On Fri, Mar 10, 2017 at 12:12:46AM +0100, Wolfram Sang wrote: > > Dmitry, > > > > On Thu, Mar 09, 2017 at 02:16:37PM -0800, Dmitry Torokhov wrote: > > > i2c bus has 2 different types of device belonging to the same bus and > > > bus notifiers use device type to distinguish between adapters and clients. > > > Previously we only had i2c_adapter_type exported, which made code wanting > > > to work with i2c_client devices test for type not equal to adapter type. > > > This unfortunately is not safe if we ever add another type to the bus, > > > so let's export i2c_client_type as well. > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > --- > > > > > > Wolfram, this is the patch I was talking about in the other mail. > > > > I see. From a glimpse, I am fine with the patch. I'll add Jean Delvare > > to CC, though, in case I missed some detail he still knows. Furthermore, > > while I agree that testing for "not adapter" when one means "is client" > > is not nice, is there a bigger benefit than being correct in your queue? > > No, just my dislike of testing for "dev->type != &i2c_adapter_type" in > the new i2c bus notifier when we want to work with i2c clients. I might not answered your question ;) I use i2c_client_type export in patch #6 of this series (I'll add you to CC in a moment), and I have some other patches that should use it as well. Thanks. -- Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Jean Delvare <jdelvare@suse.de> |
|---|---|
| Date | 2017-03-13 15:00 +0100 |
| Message-ID | <tkyFY-1ik-9@gated-at.bofh.it> |
| In reply to | #1596465 |
Hi Dmitry,
On Fri, 10 Mar 2017 00:12:46 +0100, Wolfram Sang wrote:
> On Thu, Mar 09, 2017 at 02:16:37PM -0800, Dmitry Torokhov wrote:
> > i2c bus has 2 different types of device belonging to the same bus and
> > bus notifiers use device type to distinguish between adapters and clients.
Out of curiosity, is this something unusual, or other bus types do the
same?
> > Previously we only had i2c_adapter_type exported, which made code wanting
> > to work with i2c_client devices test for type not equal to adapter type.
> > This unfortunately is not safe if we ever add another type to the bus,
> > so let's export i2c_client_type as well.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >
> > Wolfram, this is the patch I was talking about in the other mail.
>
> I see. From a glimpse, I am fine with the patch. I'll add Jean Delvare
> to CC, though, in case I missed some detail he still knows. Furthermore,
> while I agree that testing for "not adapter" when one means "is client"
> is not nice, is there a bigger benefit than being correct in your queue?
No objection from me.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
> >
> > drivers/i2c/i2c-core.c | 4 ++--
> > include/linux/i2c.h | 1 +
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> > index 34a5115484dd..446e341e9508 100644
> > --- a/drivers/i2c/i2c-core.c
> > +++ b/drivers/i2c/i2c-core.c
> > @@ -74,7 +74,6 @@
> > static DEFINE_MUTEX(core_lock);
> > static DEFINE_IDR(i2c_adapter_idr);
> >
> > -static struct device_type i2c_client_type;
> > static int i2c_detect(struct i2c_adapter *adapter, struct i2c_driver *driver);
> >
> > static struct static_key i2c_trace_msg = STATIC_KEY_INIT_FALSE;
> > @@ -1096,11 +1095,12 @@ struct bus_type i2c_bus_type = {
> > };
> > EXPORT_SYMBOL_GPL(i2c_bus_type);
> >
> > -static struct device_type i2c_client_type = {
> > +struct device_type i2c_client_type = {
> > .groups = i2c_dev_groups,
> > .uevent = i2c_device_uevent,
> > .release = i2c_client_dev_release,
> > };
> > +EXPORT_SYMBOL_GPL(i2c_client_type);
> >
> >
> > /**
> > diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> > index 2cc3988d127b..89ca5e56b433 100644
> > --- a/include/linux/i2c.h
> > +++ b/include/linux/i2c.h
> > @@ -37,6 +37,7 @@
> >
> > extern struct bus_type i2c_bus_type;
> > extern struct device_type i2c_adapter_type;
> > +extern struct device_type i2c_client_type;
> >
> > /* --- General options ------------------------------------------------ */
> >
> > --
> > 2.12.0.246.ga2ecc84866-goog
> >
--
Jean Delvare
SUSE L3 Support
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web