Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1595865 > unrolled thread
| Started by | Michał Kępień <kernel@kempniu.pl> |
|---|---|
| First post | 2017-03-09 11:10 +0100 |
| Last post | 2017-03-13 17:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly Michał Kępień <kernel@kempniu.pl> - 2017-03-09 11:10 +0100
Re: [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly Alex Hung <alex.hung@canonical.com> - 2017-03-13 11:40 +0100
Re: [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 17:20 +0100
| From | Michał Kępień <kernel@kempniu.pl> |
|---|---|
| Date | 2017-03-09 11:10 +0100 |
| Subject | [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly |
| Message-ID | <tj3bb-3I3-9@gated-at.bofh.it> |
devm_input_allocate_device() already causes the supplied struct device to be set as the parent of the input device, so doing it again is redundant. Signed-off-by: Michał Kępień <kernel@kempniu.pl> --- This patch needs my recent intel-hid cleanup series to apply cleanly. In other words, it should apply on top of testing, but not for-next. drivers/platform/x86/intel-hid.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index 5eab31659cba..b40059aba856 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c @@ -152,7 +152,6 @@ static int intel_hid_input_setup(struct platform_device *device) if (ret) return ret; - priv->input_dev->dev.parent = &device->dev; priv->input_dev->name = "Intel HID events"; priv->input_dev->id.bustype = BUS_HOST; @@ -173,7 +172,6 @@ static int intel_button_array_input_setup(struct platform_device *device) if (ret) return ret; - priv->array->dev.parent = &device->dev; priv->array->name = "Intel HID 5 button array"; priv->array->id.bustype = BUS_HOST; -- 2.12.0
[toc] | [next] | [standalone]
| From | Alex Hung <alex.hung@canonical.com> |
|---|---|
| Date | 2017-03-13 11:40 +0100 |
| Subject | Re: [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly |
| Message-ID | <tkvyp-7D9-3@gated-at.bofh.it> |
| In reply to | #1595865 |
On 2017-03-09 05:36 PM, Michał Kępień wrote: > devm_input_allocate_device() already causes the supplied struct device > to be set as the parent of the input device, so doing it again is > redundant. > > Signed-off-by: Michał Kępień <kernel@kempniu.pl> > --- > This patch needs my recent intel-hid cleanup series to apply cleanly. > In other words, it should apply on top of testing, but not for-next. > > drivers/platform/x86/intel-hid.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c > index 5eab31659cba..b40059aba856 100644 > --- a/drivers/platform/x86/intel-hid.c > +++ b/drivers/platform/x86/intel-hid.c > @@ -152,7 +152,6 @@ static int intel_hid_input_setup(struct platform_device *device) > if (ret) > return ret; > > - priv->input_dev->dev.parent = &device->dev; > priv->input_dev->name = "Intel HID events"; > priv->input_dev->id.bustype = BUS_HOST; > > @@ -173,7 +172,6 @@ static int intel_button_array_input_setup(struct platform_device *device) > if (ret) > return ret; > > - priv->array->dev.parent = &device->dev; > priv->array->name = "Intel HID 5 button array"; > priv->array->id.bustype = BUS_HOST; > > The patch, on top of previous patches, is tested on Latitude 7480 Reviewed-and-tested-by: Alex Hung <alex.hung@canonical.com>
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-03-13 17:20 +0100 |
| Subject | Re: [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly |
| Message-ID | <tkARs-34n-31@gated-at.bofh.it> |
| In reply to | #1599186 |
On Mon, Mar 13, 2017 at 12:37 PM, Alex Hung <alex.hung@canonical.com> wrote: > On 2017-03-09 05:36 PM, Michał Kępień wrote: >> >> devm_input_allocate_device() already causes the supplied struct device >> to be set as the parent of the input device, so doing it again is >> redundant. >> >> Signed-off-by: Michał Kępień <kernel@kempniu.pl> Pushed to testing, thanks. > > The patch, on top of previous patches, is tested on Latitude 7480 > > Reviewed-and-tested-by: Alex Hung <alex.hung@canonical.com> Alex, this tag is not recognized by patchwork :-(, It would be nice to use separate tags. I would join them if needed (usually when they sent against cover letter). -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web