Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598945 > unrolled thread

[PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

Back to article view | Back to linux.kernel

Contents

  [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given changbin.du@intel.com - 2017-03-13 09:40 +0100

#1598945 — [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

From: Changbin Du <changbin.du@intel.com>

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first. This patch forbid adding any overhead* field if there is one
already given.

Signed-off-by: Changbin Du <changbin.du@intel.com>
---
 tools/perf/util/sort.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index b6db140..7695b54 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2543,6 +2543,13 @@ static char *setup_overhead(char *keys)
 	if (sort__mode == SORT_MODE__DIFF)
 		return keys;
 
+	/*
+	 * Only insert overhead && overhead_children when
+	 * no overhead* field given.
+	 */
+	if (strstr(keys, "overhead"))
+		return keys;
+
 	keys = prefix_if_not_in("overhead", keys);
 
 	if (symbol_conf.cumulate_callchain)
-- 
2.7.4

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web