Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1597930 > unrolled thread
| Started by | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-03-10 16:50 +0100 |
| Last post | 2017-03-12 15:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] staging: dvb-frontends: removed code in comments. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-10 16:50 +0100
Re: [PATCH 2/2] staging: dvb-frontends: removed code in comments. Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 15:30 +0100
| From | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-03-10 16:50 +0100 |
| Subject | [PATCH 2/2] staging: dvb-frontends: removed code in comments. |
| Message-ID | <tjuXL-63f-7@gated-at.bofh.it> |
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/media/dvb-frontends/drxk_hard.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c index 7e1bbbaad625..2fe493768003 100644 --- a/drivers/media/dvb-frontends/drxk_hard.c +++ b/drivers/media/dvb-frontends/drxk_hard.c @@ -5283,7 +5283,6 @@ static int qam_set_symbolrate(struct drxk_state *state) /* Select & calculate correct IQM rate */ adc_frequency = (state->m_sys_clock_freq * 1000) / 3; ratesel = 0; - /* printk(KERN_DEBUG "drxk: SR %d\n", state->props.symbol_rate); */ if (state->props.symbol_rate <= 1188750) ratesel = 3; else if (state->props.symbol_rate <= 2377500) -- 2.11.0
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-12 15:30 +0100 |
| Message-ID | <tkcFr-2Iv-1@gated-at.bofh.it> |
| In reply to | #1597930 |
On Fri, Mar 10, 2017 at 09:16:32PM +0530, Arushi Singhal wrote: > Commenting Code Is a Bad Idea. No, "Commenting code is a good idea". I think you mean "commenting out code is a bad idea", correct? And no need for putting the sentance in all caps. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web