Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600191 > unrolled thread

Re: [PATCH v7 2/2] backlight arcxcnn add support for ArcticSand devices

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v7 2/2] backlight arcxcnn add support for ArcticSand  devices Daniel Thompson <daniel.thompson@linaro.org> - 2017-03-14 11:20 +0100
    Re: [PATCH v7 2/2] backlight arcxcnn add support for ArcticSand  devices Lee Jones <lee.jones@linaro.org> - 2017-03-14 12:30 +0100
    Re: [PATCH v7 2/2] backlight arcxcnn add support for ArcticSand  devices Brian Dodge <bdodge@arcticsand.com> - 2017-03-14 17:00 +0100
      Re: [PATCH v7 2/2] backlight arcxcnn add support for ArcticSand  devices Daniel Thompson <daniel.thompson@linaro.org> - 2017-03-14 17:20 +0100

#1600191 — Re: [PATCH v7 2/2] backlight arcxcnn add support for ArcticSand devices

On 13/03/17 18:22, Olimpiu Dejeu wrote:
> backlight: Add support for Arctic Sand LED backlight driver chips
> This driver provides support for the Arctic Sand arc2c0608 chip,
>     and provides a framework to support future devices.
> Signed-off-by: Olimpiu Dejeu <olimpiu@arcticsand.com>

Please could you also submit a patch to add arc to
./Documentation/devicetree/bindings/vendor-prefixes.txt.

checkpatch.pl should have been asking you to do since v1 but only if you 
test the patch series against a clean kernel (tools such as aiaiai can 
help with this).

However, once that is attended to:

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.

[toc] | [next] | [standalone]

#1600239

On Tue, 14 Mar 2017, Daniel Thompson wrote:

> On 13/03/17 18:22, Olimpiu Dejeu wrote:
> > backlight: Add support for Arctic Sand LED backlight driver chips
> > This driver provides support for the Arctic Sand arc2c0608 chip,
> >     and provides a framework to support future devices.
> > Signed-off-by: Olimpiu Dejeu <olimpiu@arcticsand.com>
> 
> Please could you also submit a patch to add arc to
> ./Documentation/devicetree/bindings/vendor-prefixes.txt.
> 
> checkpatch.pl should have been asking you to do since v1 but only if you
> test the patch series against a clean kernel (tools such as aiaiai can help
> with this).
> 
> However, once that is attended to:
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

Please re-send the whole set 'threaded' once complete.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1600641

Hi Daniel,

Yes checkpatch.pl was telling us this. I didn't think we had the 
"authority" to modify that file.   Is it OK if we put the 
vendor-prefixes.txt change in the first patch (device tree bindings) or 
so you think we should have an 0003 patch for just that?

Brian

On 03/14/2017 06:16 AM, Daniel Thompson wrote:
> On 13/03/17 18:22, Olimpiu Dejeu wrote:
>> backlight: Add support for Arctic Sand LED backlight driver chips
>> This driver provides support for the Arctic Sand arc2c0608 chip,
>>     and provides a framework to support future devices.
>> Signed-off-by: Olimpiu Dejeu <olimpiu@arcticsand.com>
>
> Please could you also submit a patch to add arc to
> ./Documentation/devicetree/bindings/vendor-prefixes.txt.
>
> checkpatch.pl should have been asking you to do since v1 but only if 
> you test the patch series against a clean kernel (tools such as aiaiai 
> can help with this).
>
> However, once that is attended to:
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>
> Daniel.

[toc] | [prev] | [next] | [standalone]

#1600660

On 14/03/17 15:53, Brian Dodge wrote:
> Hi Daniel,
>
> Yes checkpatch.pl was telling us this. I didn't think we had the
> "authority" to modify that file.

You don't really need authority to propose changes (e.g. send a patch). 
I guess you might attract sharp words from a maintainer if the proposed 
change were conspicuously reckless or extremely short sighted ("my use 
case is the only one that really matters") but I don't see any risk of 
that here.

Think of it like this: if folks with @arcticsand.com mail addresses 
don't try to document the vendor prefix, who will?


 > Is it OK if we put the
> vendor-prefixes.txt change in the first patch (device tree bindings) or
> so you think we should have an 0003 patch for just that?

Personally I'd add it as a new patch but I'd make it the *first* patch 
in the series.


Daniel.


PS Top posting *is* something that will eventually attract sharp words
    from some maintainers ;-)


> On 03/14/2017 06:16 AM, Daniel Thompson wrote:
>> On 13/03/17 18:22, Olimpiu Dejeu wrote:
>>> backlight: Add support for Arctic Sand LED backlight driver chips
>>> This driver provides support for the Arctic Sand arc2c0608 chip,
>>>     and provides a framework to support future devices.
>>> Signed-off-by: Olimpiu Dejeu <olimpiu@arcticsand.com>
>>
>> Please could you also submit a patch to add arc to
>> ./Documentation/devicetree/bindings/vendor-prefixes.txt.
>>
>> checkpatch.pl should have been asking you to do since v1 but only if
>> you test the patch series against a clean kernel (tools such as aiaiai
>> can help with this).
>>
>> However, once that is attended to:
>>
>> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>>
>>
>> Daniel.
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web