Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600294 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-03-14 14:00 +0100 |
| Last post | 2017-03-14 15:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[RESEND PATCH] irqchip: mvebu-odmi: select GENERIC_MSI_IRQ_DOMAIN Arnd Bergmann <arnd@arndb.de> - 2017-03-14 14:00 +0100
Re: [RESEND PATCH] irqchip: mvebu-odmi: select GENERIC_MSI_IRQ_DOMAIN Marc Zyngier <marc.zyngier@arm.com> - 2017-03-14 15:00 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-03-14 14:00 +0100 |
| Subject | [RESEND PATCH] irqchip: mvebu-odmi: select GENERIC_MSI_IRQ_DOMAIN |
| Message-ID | <tkUdr-cW-5@gated-at.bofh.it> |
This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we
may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled:
drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type
static struct msi_domain_ops odmi_msi_ops = {
^~~~~~~~~~~~~~
drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type
static struct msi_domain_info odmi_msi_domain_info = {
^~~~~~~~~~~~~~~
drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags'
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
^~~~~
drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function)
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'?
Selecting the option from this driver seems to solve this nicely, though I could
not find any other instance of this in irqchip drivers.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Originally sent on Feb 14, but for some reason didn't make it into v4.11-rc2
and is still needed to build some randconfig configurations.
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 125528f39e92..8162121bb1bc 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -262,6 +262,7 @@ config IRQ_MXS
config MVEBU_ODMI
bool
+ select GENERIC_MSI_IRQ_DOMAIN
config MVEBU_PIC
bool
--
2.9.0
[toc] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2017-03-14 15:00 +0100 |
| Message-ID | <tkV9w-Uf-15@gated-at.bofh.it> |
| In reply to | #1600294 |
On 14/03/17 12:54, Arnd Bergmann wrote:
> This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we
> may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled:
>
> drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type
> static struct msi_domain_ops odmi_msi_ops = {
> ^~~~~~~~~~~~~~
> drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type
> static struct msi_domain_info odmi_msi_domain_info = {
> ^~~~~~~~~~~~~~~
> drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags'
> .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
> ^~~~~
> drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function)
> .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
> ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'?
>
> Selecting the option from this driver seems to solve this nicely, though I could
> not find any other instance of this in irqchip drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Originally sent on Feb 14, but for some reason didn't make it into v4.11-rc2
> and is still needed to build some randconfig configurations.
Ah, my bad. I had it stashed, and must have messed up my branch at some
point. I'm queuing it now and I'll send a PR to Thomas with whatever is
left by the end of the week.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web