Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592024 > unrolled thread

[PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

Started byRobin van der Gracht <robin@protonic.nl>
First post2017-03-03 15:50 +0100
Last post2017-03-15 07:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock Robin van der Gracht <robin@protonic.nl> - 2017-03-03 15:50 +0100
    Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3  clock Robin van der Gracht <robin@protonic.nl> - 2017-03-14 12:00 +0100
      Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3  clock Shawn Guo <shawnguo@kernel.org> - 2017-03-15 07:30 +0100

#1592024 — [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

FromRobin van der Gracht <robin@protonic.nl>
Date2017-03-03 15:50 +0100
Subject[PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock
Message-ID<tgWGT-2zu-35@gated-at.bofh.it>
The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
---
Fixed another title typo in v3

 drivers/clk/imx/clk-imx6ul.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index 75c35fb..dbd6e59 100644
--- a/drivers/clk/imx/clk-imx6ul.c
+++ b/drivers/clk/imx/clk-imx6ul.c
@@ -73,7 +73,7 @@ static struct clk *clks[IMX6UL_CLK_END];
 static struct clk_onecell_data clk_data;
 
 static int const clks_init_on[] __initconst = {
-	IMX6UL_CLK_AIPSTZ1, IMX6UL_CLK_AIPSTZ2, IMX6UL_CLK_AIPSTZ3,
+	IMX6UL_CLK_AIPSTZ1, IMX6UL_CLK_AIPSTZ2,
 	IMX6UL_CLK_AXI, IMX6UL_CLK_ARM, IMX6UL_CLK_ROM,
 	IMX6UL_CLK_MMDC_P0_FAST, IMX6UL_CLK_MMDC_P0_IPG,
 };
@@ -341,9 +341,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
 	clks[IMX6UL_CLK_GPT2_SERIAL]	= imx_clk_gate2("gpt2_serial",	"perclk",	base + 0x68,	26);
 	clks[IMX6UL_CLK_UART2_IPG]	= imx_clk_gate2("uart2_ipg",	"ipg",		base + 0x68,	28);
 	clks[IMX6UL_CLK_UART2_SERIAL]	= imx_clk_gate2("uart2_serial",	"uart_podf",	base + 0x68,	28);
-	if (clk_on_imx6ul())
-		clks[IMX6UL_CLK_AIPSTZ3]	= imx_clk_gate2("aips_tz3",	"ahb",		base + 0x68,	30);
-	else if (clk_on_imx6ull())
+	if (clk_on_imx6ull())
 		clks[IMX6UL_CLK_AIPSTZ3]	= imx_clk_gate2("aips_tz3",	"ahb",		 base + 0x80,	18);
 
 	/* CCGR1 */
@@ -482,6 +480,9 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
 	for (i = 0; i < ARRAY_SIZE(clks_init_on); i++)
 		clk_prepare_enable(clks[clks_init_on[i]]);
 
+	if (clk_on_imx6ull())
+		clk_prepare_enable(clks[IMX6UL_CLK_AIPSTZ3]);
+
 	if (IS_ENABLED(CONFIG_USB_MXS_PHY)) {
 		clk_prepare_enable(clks[IMX6UL_CLK_USBPHY1_GATE]);
 		clk_prepare_enable(clks[IMX6UL_CLK_USBPHY2_GATE]);
-- 
2.9.3

[toc] | [next] | [standalone]


#1600213 — Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

FromRobin van der Gracht <robin@protonic.nl>
Date2017-03-14 12:00 +0100
SubjectRe: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock
Message-ID<tkSlj-7kN-7@gated-at.bofh.it>
In reply to#1592024
On Fri,  3 Mar 2017 15:14:05 +0100
Robin van der Gracht <robin@protonic.nl> wrote:

> The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>

Sasha or Shawn would you mind pushing this patch upstream?
I don't have a path.

Best regards,
Robin

[toc] | [prev] | [next] | [standalone]


#1601088 — Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

FromShawn Guo <shawnguo@kernel.org>
Date2017-03-15 07:30 +0100
SubjectRe: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock
Message-ID<tlaBz-3D3-3@gated-at.bofh.it>
In reply to#1600213
On Tue, Mar 14, 2017 at 11:55:14AM +0100, Robin van der Gracht wrote:
> On Fri,  3 Mar 2017 15:14:05 +0100
> Robin van der Gracht <robin@protonic.nl> wrote:
> 
> > The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
> > 
> > Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> 
> Sasha or Shawn would you mind pushing this patch upstream?
> I don't have a path.

I think Stephen will take care of it.

Shawn

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web