Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599250 > unrolled thread
| Started by | Roger Quadros <rogerq@ti.com> |
|---|---|
| First post | 2017-03-13 13:00 +0100 |
| Last post | 2017-03-14 13:10 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags Roger Quadros <rogerq@ti.com> - 2017-03-13 13:00 +0100
Re: [PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags Sekhar Nori <nsekhar@ti.com> - 2017-03-13 14:40 +0100
Re: [PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags Roger Quadros <rogerq@ti.com> - 2017-03-14 11:50 +0100
[PATCH v2 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags Roger Quadros <rogerq@ti.com> - 2017-03-14 13:10 +0100
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2017-03-13 13:00 +0100 |
| Subject | [PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags |
| Message-ID | <tkwNQ-8qX-7@gated-at.bofh.it> |
From: Sekhar Nori <nsekhar@ti.com>
'flags' member of omap_hwmod structure is fast running
out of space with 16 different flags already defined.
Make flags a 32-bit entity so as to allow for more flags.
This results is a ~2.3K data section size increase with
TI config fragments.
before:
text data bss dec hex filename
8886648 610452 261876 9758976 94e900 vmlinux
after:
text data bss dec hex filename
8886584 612820 261876 9761280 94f200 vmlinux
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
arch/arm/mach-omap2/omap_hwmod.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.h b/arch/arm/mach-omap2/omap_hwmod.h
index 7890401..9e1c4ed 100644
--- a/arch/arm/mach-omap2/omap_hwmod.h
+++ b/arch/arm/mach-omap2/omap_hwmod.h
@@ -698,7 +698,7 @@ struct omap_hwmod {
struct list_head node;
struct omap_hwmod_ocp_if *_mpu_port;
unsigned int (*xlate_irq)(unsigned int);
- u16 flags;
+ u32 flags;
u8 mpu_rt_idx;
u8 response_lat;
u8 rst_lines_cnt;
--
2.7.4
[toc] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-03-13 14:40 +0100 |
| Subject | Re: [PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags |
| Message-ID | <tkymC-1ax-7@gated-at.bofh.it> |
| In reply to | #1599250 |
On Monday 13 March 2017 05:23 PM, Roger Quadros wrote: > From: Sekhar Nori <nsekhar@ti.com> > > 'flags' member of omap_hwmod structure is fast running > out of space with 16 different flags already defined. > > Make flags a 32-bit entity so as to allow for more flags. > > This results is a ~2.3K data section size increase with > TI config fragments. This line needs to be changed to refer to omap2plus_defconfig. > > before: > text data bss dec hex filename > 8886648 610452 261876 9758976 94e900 vmlinux > > after: > text data bss dec hex filename > 8886584 612820 261876 9761280 94f200 vmlinux I guess this data is probably stale as well. Here is the before and after numbers using omap2plus_defconfig on v4.11-rc2 before: text data bss dec hex filename 8186930 3082444 8252992 19522366 129e33e vmlinux after: text data bss dec hex filename 8186922 3084812 8252992 19524726 129ec76 vmlinux The size increase remains at ~2.3K in data section. Thanks, Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2017-03-14 11:50 +0100 |
| Subject | Re: [PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags |
| Message-ID | <tkSbE-7fP-7@gated-at.bofh.it> |
| In reply to | #1599366 |
On 13/03/17 15:35, Sekhar Nori wrote: > On Monday 13 March 2017 05:23 PM, Roger Quadros wrote: >> From: Sekhar Nori <nsekhar@ti.com> >> >> 'flags' member of omap_hwmod structure is fast running >> out of space with 16 different flags already defined. >> >> Make flags a 32-bit entity so as to allow for more flags. >> >> This results is a ~2.3K data section size increase with >> TI config fragments. > > This line needs to be changed to refer to omap2plus_defconfig. OK. > >> >> before: >> text data bss dec hex filename >> 8886648 610452 261876 9758976 94e900 vmlinux >> >> after: >> text data bss dec hex filename >> 8886584 612820 261876 9761280 94f200 vmlinux > > I guess this data is probably stale as well. Here is the before and > after numbers using omap2plus_defconfig on v4.11-rc2 > > before: > text data bss dec hex filename > 8186930 3082444 8252992 19522366 129e33e vmlinux > > after: > text data bss dec hex filename > 8186922 3084812 8252992 19524726 129ec76 vmlinux > > The size increase remains at ~2.3K in data section. > Thanks for the new figures. I'll resend the patch with updated data. -- cheers, -roger
[toc] | [prev] | [next] | [standalone]
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2017-03-14 13:10 +0100 |
| Subject | [PATCH v2 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags |
| Message-ID | <tkTr3-8mX-7@gated-at.bofh.it> |
| In reply to | #1599250 |
From: Sekhar Nori <nsekhar@ti.com>
'flags' member of omap_hwmod structure is fast running
out of space with 16 different flags already defined.
Make flags a 32-bit entity so as to allow for more flags.
This results is a ~2.3K data section size increase with
omap2plus_defconfig on v4.11-rc2.
before:
text data bss dec hex filename
8186930 3082444 8252992 19522366 129e33e vmlinux
after:
text data bss dec hex filename
8186922 3084812 8252992 19524726 129ec76 vmlinux
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
v2:
-Updated size metrics for v4.11-rc2 in commit message.
arch/arm/mach-omap2/omap_hwmod.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.h b/arch/arm/mach-omap2/omap_hwmod.h
index 7890401..9e1c4ed 100644
--- a/arch/arm/mach-omap2/omap_hwmod.h
+++ b/arch/arm/mach-omap2/omap_hwmod.h
@@ -698,7 +698,7 @@ struct omap_hwmod {
struct list_head node;
struct omap_hwmod_ocp_if *_mpu_port;
unsigned int (*xlate_irq)(unsigned int);
- u16 flags;
+ u32 flags;
u8 mpu_rt_idx;
u8 response_lat;
u8 rst_lines_cnt;
--
2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web