Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599364 > unrolled thread

Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register

Started byWilliam Breathitt Gray <vilhelm.gray@gmail.com>
First post2017-03-13 14:40 +0100
Last post2017-03-15 06:40 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing  flag register William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-03-13 14:40 +0100
    Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing  flag register Jonathan Cameron <jic23@kernel.org> - 2017-03-13 22:40 +0100
      Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing  flag register William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-03-14 16:10 +0100
        Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing  flag register Greg KH <gregkh@linuxfoundation.org> - 2017-03-15 06:40 +0100

#1599364 — Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register

FromWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Date2017-03-13 14:40 +0100
SubjectRe: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register
Message-ID<tkymB-1ax-1@gated-at.bofh.it>
On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>On 09/02/17 15:03, William Breathitt Gray wrote:
>> The flag register is offset by 1 from the respective channel data
>> register. This patch fixes an off-by-one error when attempting to read a
>> channel flag register where the base address was not properly offset.
>> 
>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>Applied to the fixes-togreg-post-rc1 branch of iio.git
>Clue to when this will go upstream is in the name ;)
>
>Thanks,
>
>Jonathan

Hi Jonathan,

I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
Is this patch on track to appear in stable, or should I explicitly CC
stable@vger.kernel.org to pick this up?

Thanks,

William Breathitt Gray

>> ---
>>  drivers/iio/counter/104-quad-8.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>> index a5913e97945e..f9b8fc9ae13f 100644
>> --- a/drivers/iio/counter/104-quad-8.c
>> +++ b/drivers/iio/counter/104-quad-8.c
>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>>  			return IIO_VAL_INT;
>>  		}
>>  
>> -		flags = inb(base_offset);
>> +		flags = inb(base_offset + 1);
>>  		borrow = flags & BIT(0);
>>  		carry = !!(flags & BIT(1));
>>  
>>

[toc] | [next] | [standalone]

#1599845

FromJonathan Cameron <jic23@kernel.org>
Date2017-03-13 22:40 +0100
Message-ID<tkFR8-6IY-23@gated-at.bofh.it>
In reply to#1599364
On 13/03/17 13:33, William Breathitt Gray wrote:
> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>> On 09/02/17 15:03, William Breathitt Gray wrote:
>>> The flag register is offset by 1 from the respective channel data
>>> register. This patch fixes an off-by-one error when attempting to read a
>>> channel flag register where the base address was not properly offset.
>>>
>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>> Applied to the fixes-togreg-post-rc1 branch of iio.git
>> Clue to when this will go upstream is in the name ;)
>>
>> Thanks,
>>
>> Jonathan
> 
> Hi Jonathan,
> 
> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
> Is this patch on track to appear in stable, or should I explicitly CC
> stable@vger.kernel.org to pick this up?
I was half asleep and failed to tag this in the first place.

Send an email to stable@vger.kernel.org with the commit ID and a request
that it is picked up.  Cc me.

Jonathan
> 
> Thanks,
> 
> William Breathitt Gray
> 
>>> ---
>>>  drivers/iio/counter/104-quad-8.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>>> index a5913e97945e..f9b8fc9ae13f 100644
>>> --- a/drivers/iio/counter/104-quad-8.c
>>> +++ b/drivers/iio/counter/104-quad-8.c
>>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>>>  			return IIO_VAL_INT;
>>>  		}
>>>  
>>> -		flags = inb(base_offset);
>>> +		flags = inb(base_offset + 1);
>>>  		borrow = flags & BIT(0);
>>>  		carry = !!(flags & BIT(1));
>>>  
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[toc] | [prev] | [next] | [standalone]

#1600560

FromWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Date2017-03-14 16:10 +0100
Message-ID<tkWfh-1T2-49@gated-at.bofh.it>
In reply to#1599845
On Mon, Mar 13, 2017 at 09:33:45PM +0000, Jonathan Cameron wrote:
>On 13/03/17 13:33, William Breathitt Gray wrote:
>> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>>> On 09/02/17 15:03, William Breathitt Gray wrote:
>>>> The flag register is offset by 1 from the respective channel data
>>>> register. This patch fixes an off-by-one error when attempting to read a
>>>> channel flag register where the base address was not properly offset.
>>>>
>>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>>> Applied to the fixes-togreg-post-rc1 branch of iio.git
>>> Clue to when this will go upstream is in the name ;)
>>>
>>> Thanks,
>>>
>>> Jonathan
>> 
>> Hi Jonathan,
>> 
>> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
>> Is this patch on track to appear in stable, or should I explicitly CC
>> stable@vger.kernel.org to pick this up?
>I was half asleep and failed to tag this in the first place.
>
>Send an email to stable@vger.kernel.org with the commit ID and a request
>that it is picked up.  Cc me.
>
>Jonathan
>> 
>> Thanks,
>> 
>> William Breathitt Gray
>> 

Hello,

This patch was merged into Linus' tree as commit ca8d8e03b4c9 ("iio:
104-quad-8: Fix off-by-one error when addressing flag register"). This
fix should be merged into the 4.10 stable tree as well to fix an
off-by-one error which causes garbage data to be read as count values --
effectively preventing proper usage of the driver.

This patch fixes commit 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support
for the ACCES 104-QUAD-8").

Thank you,

William Breathitt Gray

>>>> ---
>>>>  drivers/iio/counter/104-quad-8.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>>>> index a5913e97945e..f9b8fc9ae13f 100644
>>>> --- a/drivers/iio/counter/104-quad-8.c
>>>> +++ b/drivers/iio/counter/104-quad-8.c
>>>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>>>>  			return IIO_VAL_INT;
>>>>  		}
>>>>  
>>>> -		flags = inb(base_offset);
>>>> +		flags = inb(base_offset + 1);
>>>>  		borrow = flags & BIT(0);
>>>>  		carry = !!(flags & BIT(1));
>>>>  
>>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> 
>

[toc] | [prev] | [next] | [standalone]

#1601070

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-03-15 06:40 +0100
Message-ID<tl9Pb-307-1@gated-at.bofh.it>
In reply to#1600560
On Tue, Mar 14, 2017 at 11:00:43AM -0400, William Breathitt Gray wrote:
> On Mon, Mar 13, 2017 at 09:33:45PM +0000, Jonathan Cameron wrote:
> >On 13/03/17 13:33, William Breathitt Gray wrote:
> >> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
> >>> On 09/02/17 15:03, William Breathitt Gray wrote:
> >>>> The flag register is offset by 1 from the respective channel data
> >>>> register. This patch fixes an off-by-one error when attempting to read a
> >>>> channel flag register where the base address was not properly offset.
> >>>>
> >>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> >>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> >>> Applied to the fixes-togreg-post-rc1 branch of iio.git
> >>> Clue to when this will go upstream is in the name ;)
> >>>
> >>> Thanks,
> >>>
> >>> Jonathan
> >> 
> >> Hi Jonathan,
> >> 
> >> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
> >> Is this patch on track to appear in stable, or should I explicitly CC
> >> stable@vger.kernel.org to pick this up?
> >I was half asleep and failed to tag this in the first place.
> >
> >Send an email to stable@vger.kernel.org with the commit ID and a request
> >that it is picked up.  Cc me.
> >
> >Jonathan
> >> 
> >> Thanks,
> >> 
> >> William Breathitt Gray
> >> 
> 
> Hello,
> 
> This patch was merged into Linus' tree as commit ca8d8e03b4c9 ("iio:
> 104-quad-8: Fix off-by-one error when addressing flag register"). This
> fix should be merged into the 4.10 stable tree as well to fix an
> off-by-one error which causes garbage data to be read as count values --
> effectively preventing proper usage of the driver.
> 
> This patch fixes commit 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support
> for the ACCES 104-QUAD-8").

Now queued up, thanks.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web