Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599780 > unrolled thread

[PATCH v3 0/2] staging: checkpatch cleanups

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 0/2] staging: checkpatch cleanups Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-13 21:30 +0100
    [PATCH v3 2/2] staging: dvb-frontends: removed code in comments. Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-13 21:30 +0100
    [PATCH v3 1/2] staging: speakup: identation should use tabs Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-13 21:30 +0100
      Re: [PATCH v3 1/2] staging: speakup: identation should use tabs Greg KH <gregkh@linuxfoundation.org> - 2017-03-13 23:10 +0100
    Re: [PATCH v3 0/2] staging: checkpatch cleanups Greg KH <gregkh@linuxfoundation.org> - 2017-03-13 23:10 +0100
      Re: [PATCH v3 0/2] staging: checkpatch cleanups Greg KH <gregkh@linuxfoundation.org> - 2017-03-16 08:10 +0100

#1599780 — [PATCH v3 0/2] staging: checkpatch cleanups

Improve readability by fixing multiple checkpatch.pl
issues in drivers. 

Arushi Singhal (2):
  staging: speakup: identation should use tabs
  staging: dvb-frontends: removed code in comments.

 drivers/media/dvb-frontends/drxk_hard.c  |   1 -
 drivers/staging/speakup/speakup_dtlk.h   |  10 +++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

-- 
Changes since v3:
 -change the subject of cover letter.

2.11.0

[toc] | [next] | [standalone]

#1599782 — [PATCH v3 2/2] staging: dvb-frontends: removed code in comments.

Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments  does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 changes in v3
 - Improve the commit message

 drivers/media/dvb-frontends/drxk_hard.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c
index 7e1bbbaad625..2fe493768003 100644
--- a/drivers/media/dvb-frontends/drxk_hard.c
+++ b/drivers/media/dvb-frontends/drxk_hard.c
@@ -5283,7 +5283,6 @@ static int qam_set_symbolrate(struct drxk_state *state)
 	/* Select & calculate correct IQM rate */
 	adc_frequency = (state->m_sys_clock_freq * 1000) / 3;
 	ratesel = 0;
-	/* printk(KERN_DEBUG "drxk: SR %d\n", state->props.symbol_rate); */
 	if (state->props.symbol_rate <= 1188750)
 		ratesel = 3;
 	else if (state->props.symbol_rate <= 2377500)
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1599783 — [PATCH v3 1/2] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/speakup/speakup_dtlk.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h
index b3b3cfc3db07..46d885fcfb20 100644
--- a/drivers/staging/speakup/speakup_dtlk.h
+++ b/drivers/staging/speakup/speakup_dtlk.h
@@ -24,11 +24,11 @@
 				 * usec later.
 				 */
 #define TTS_ALMOST_FULL	0x08	/* mask for AF bit: When set to 1,
-				         * indicates that less than 300 bytes
-				         * are available in the TTS input
-				         * buffer. AF is always 0 in the PCM,
-				         * TGN and CVSD modes.
-				         */
+					 * indicates that less than 300 bytes
+					 * are available in the TTS input
+					 * buffer. AF is always 0 in the PCM,
+					 * TGN and CVSD modes.
+					 */
 #define TTS_ALMOST_EMPTY 0x04	/* mask for AE bit: When set to 1,
 				 * indicates that less than 300 bytes
 				 * are remaining in DoubleTalk's input
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1599871 — Re: [PATCH v3 1/2] staging: speakup: identation should use tabs

On Tue, Mar 14, 2017 at 01:49:54AM +0530, Arushi Singhal wrote:
> Indentation should always use tabs and never spaces.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/speakup/speakup_dtlk.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

What changed from v2?

Always list it, even if nothing changed...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1599868

On Tue, Mar 14, 2017 at 01:49:52AM +0530, Arushi Singhal wrote:
> Improve readability by fixing multiple checkpatch.pl
> issues in drivers. 
> 
> Arushi Singhal (2):
>   staging: speakup: identation should use tabs
>   staging: dvb-frontends: removed code in comments.

What changed from v2?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1602007

On Thu, Mar 16, 2017 at 12:02:25PM +0530, Arushi Singhal wrote:
> 
> 
> On Tue, Mar 14, 2017 at 3:35 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
>     On Tue, Mar 14, 2017 at 01:49:52AM +0530, Arushi Singhal wrote:
>     > Improve readability by fixing multiple checkpatch.pl
>     > issues in drivers.
>     >
>     > Arushi Singhal (2):
>     >   staging: speakup: identation should use tabs
>     >   staging: dvb-frontends: removed code in comments.
> 
>     What changed from v2?
> 
>  In this patch nothing is changed from v2 but it is a patch series so have to
> write v2 everywhere.

And everywhere you also need to say why it is v2, otherwise we have no
idea :(

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web