Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596593 > unrolled thread
| Started by | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| First post | 2017-03-10 04:30 +0100 |
| Last post | 2017-03-10 09:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call Jisheng Zhang <jszhang@marvell.com> - 2017-03-10 04:30 +0100
Re: [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call Patrice CHOTARD <patrice.chotard@st.com> - 2017-03-10 09:50 +0100
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2017-03-10 04:30 +0100 |
| Subject | [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call |
| Message-ID | <tjjpD-67H-11@gated-at.bofh.it> |
sdhci_pltfm_init() has already set the platform drvdata for us, remove the unnecessary platform_set_drvdata() call. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- drivers/mmc/host/sdhci-st.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index ed92ce729dde..7fff6490855c 100644 --- a/drivers/mmc/host/sdhci-st.c +++ b/drivers/mmc/host/sdhci-st.c @@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev) goto err_out; } - platform_set_drvdata(pdev, host); - host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION)); dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n", -- 2.11.0
[toc] | [next] | [standalone]
| From | Patrice CHOTARD <patrice.chotard@st.com> |
|---|---|
| Date | 2017-03-10 09:50 +0100 |
| Subject | Re: [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call |
| Message-ID | <tjopk-1j2-15@gated-at.bofh.it> |
| In reply to | #1596593 |
Hi Jisheng On 03/10/2017 04:17 AM, Jisheng Zhang wrote: > sdhci_pltfm_init() has already set the platform drvdata for us, remove > the unnecessary platform_set_drvdata() call. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > --- > drivers/mmc/host/sdhci-st.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c > index ed92ce729dde..7fff6490855c 100644 > --- a/drivers/mmc/host/sdhci-st.c > +++ b/drivers/mmc/host/sdhci-st.c > @@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev) > goto err_out; > } > > - platform_set_drvdata(pdev, host); > - > host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION)); > > dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n", > Acked-by: Patrice Chotard <patrice.chotard@st.com> Thanks
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web