Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596090 > unrolled thread
| Started by | Mike Galbraith <efault@gmx.de> |
|---|---|
| First post | 2017-03-09 15:20 +0100 |
| Last post | 2017-03-09 21:50 +0100 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Mike Galbraith <efault@gmx.de> - 2017-03-09 15:20 +0100
Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Thomas Gleixner <tglx@linutronix.de> - 2017-03-09 19:00 +0100
Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Mike Galbraith <efault@gmx.de> - 2017-03-09 19:30 +0100
Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Thomas Gleixner <tglx@linutronix.de> - 2017-03-09 20:20 +0100
Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static "Tobin C. Harding" <me@tobin.cc> - 2017-03-09 21:20 +0100
Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Borislav Petkov <bp@alien8.de> - 2017-03-09 21:40 +0100
Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static Thomas Gleixner <tglx@linutronix.de> - 2017-03-09 21:50 +0100
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-03-09 15:20 +0100 |
| Subject | [regression] 72042a8c7b01 x86/purgatory: Make functions and variables static |
| Message-ID | <tj758-6kn-19@gated-at.bofh.it> |
Greetings, I bisected kdump breakage to $subject, and verified the identified culprit via revert. Seems kexec needs those variables as they were. -Mike
[toc] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2017-03-09 19:00 +0100 |
| Message-ID | <tjaw1-8vb-1@gated-at.bofh.it> |
| In reply to | #1596090 |
On Thu, 9 Mar 2017, Mike Galbraith wrote: > Greetings, > > I bisected kdump breakage to $subject, and verified the identified > culprit via revert. Seems kexec needs those variables as they were. Yuck. That does not make any sense at all. I'll try to figure out why. Thanks, tglx
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-03-09 19:30 +0100 |
| Message-ID | <tjaZ4-vl-7@gated-at.bofh.it> |
| In reply to | #1596261 |
On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote: > On Thu, 9 Mar 2017, Mike Galbraith wrote: > > > Greetings, > > > > I bisected kdump breakage to $subject, and verified the identified > > culprit via revert. Seems kexec needs those variables as they were. > > Yuck. That does not make any sense at all. I'll try to figure out why. Dunno, but I did find this. git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64 ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start", ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size", ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",
[toc] | [prev] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2017-03-09 20:20 +0100 |
| Message-ID | <tjbLr-143-21@gated-at.bofh.it> |
| In reply to | #1596296 |
On Thu, 9 Mar 2017, Mike Galbraith wrote: > On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote: > > On Thu, 9 Mar 2017, Mike Galbraith wrote: > > > > > Greetings, > > > > > > I bisected kdump breakage to $subject, and verified the identified > > > culprit via revert. Seems kexec needs those variables as they were. > > > > Yuck. That does not make any sense at all. I'll try to figure out why. > > Dunno, but I did find this. > > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64 > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start", > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size", > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start", Came so far as well. Lovely undocumented dependencies.....
[toc] | [prev] | [next] | [standalone]
| From | "Tobin C. Harding" <me@tobin.cc> |
|---|---|
| Date | 2017-03-09 21:20 +0100 |
| Message-ID | <tjcHv-1H0-17@gated-at.bofh.it> |
| In reply to | #1596352 |
On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote: > On Thu, 9 Mar 2017, Mike Galbraith wrote: > > On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote: > > > On Thu, 9 Mar 2017, Mike Galbraith wrote: > > > > > > > Greetings, > > > > > > > > I bisected kdump breakage to $subject, and verified the identified > > > > culprit via revert. Seems kexec needs those variables as they were. > > > > > > Yuck. That does not make any sense at all. I'll try to figure out why. > > > > Dunno, but I did find this. > > > > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64 > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start", > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size", > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start", > > Came so far as well. Lovely undocumented dependencies..... I'm out of my depth on this one. If there is some task I can do to save you time or effort, point me at it. thanks, Tobin.
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-03-09 21:40 +0100 |
| Message-ID | <tjd0R-1Nu-5@gated-at.bofh.it> |
| In reply to | #1596352 |
On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote:
> > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",
>
> Came so far as well. Lovely undocumented dependencies.....
Maybe that'll help a little:
https://lkml.kernel.org/r/20170103153814.GC29807@redhat.com
And yap, that thing needs a bunch of text ontop saying sh*t and why it
is magical.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2017-03-09 21:50 +0100 |
| Message-ID | <tjday-1R7-19@gated-at.bofh.it> |
| In reply to | #1596377 |
On Thu, 9 Mar 2017, Borislav Petkov wrote: > On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote: > > > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64 > > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start", > > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size", > > > ./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start", > > > > Came so far as well. Lovely undocumented dependencies..... > > Maybe that'll help a little: > > https://lkml.kernel.org/r/20170103153814.GC29807@redhat.com > > And yap, that thing needs a bunch of text ontop saying sh*t and why it > is magical. I know how to fix it, but I'll do that tomorrow with brain awake
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web