Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598469 > unrolled thread

[PATCH v2] staging: android: Replace strcpy with strlcpy

Started bysimran singhal <singhalsimran0@gmail.com>
First post2017-03-11 22:20 +0100
Last post2017-03-11 22:40 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] staging: android: Replace strcpy with strlcpy simran singhal <singhalsimran0@gmail.com> - 2017-03-11 22:20 +0100
    Re: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy  with strlcpy Julia Lawall <julia.lawall@lip6.fr> - 2017-03-11 22:30 +0100
      Re: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy  with strlcpy Julia Lawall <julia.lawall@lip6.fr> - 2017-03-11 22:40 +0100
      Re: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy  with strlcpy SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-11 22:40 +0100

#1598469 — [PATCH v2] staging: android: Replace strcpy with strlcpy

Fromsimran singhal <singhalsimran0@gmail.com>
Date2017-03-11 22:20 +0100
Subject[PATCH v2] staging: android: Replace strcpy with strlcpy
Message-ID<tjWAG-8vE-19@gated-at.bofh.it>
Replace strcpy with strlcpy as strcpy does not check for buffer
overflow.
This is found using Flawfinder.

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---

 v2:
   -Correcting the place of the parenthesis
 
 drivers/staging/android/ashmem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 7cbad0d..eb2f4ef 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name)
 	if (unlikely(asma->file))
 		ret = -EINVAL;
 	else
-		strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name);
+		strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name,
+			sizeof(asma->name + ASHMEM_NAME_PREFIX_LEN));
 
 	mutex_unlock(&ashmem_mutex);
 	return ret;
-- 
2.7.4

[toc] | [next] | [standalone]

#1598483 — Re: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy with strlcpy

FromJulia Lawall <julia.lawall@lip6.fr>
Date2017-03-11 22:30 +0100
SubjectRe: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy with strlcpy
Message-ID<tjWKl-7E-3@gated-at.bofh.it>
In reply to#1598469

On Sun, 12 Mar 2017, simran singhal wrote:

> Replace strcpy with strlcpy as strcpy does not check for buffer
> overflow.
> This is found using Flawfinder.
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>
>  v2:
>    -Correcting the place of the parenthesis
>
>  drivers/staging/android/ashmem.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 7cbad0d..eb2f4ef 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name)
>  	if (unlikely(asma->file))
>  		ret = -EINVAL;
>  	else
> -		strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name);
> +		strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name,
> +			sizeof(asma->name + ASHMEM_NAME_PREFIX_LEN));

This appears to be the old patch.

Actually, looking closer, I don't think this is right at all.  There seems
to be a goal of leaving some space at the beginning of asma->name.  So the
amount of space available for local_name would be computed using a
subtraction, not an addition.

julia

>
>  	mutex_unlock(&ashmem_mutex);
>  	return ret;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170311211725.GA12884%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

[toc] | [prev] | [next] | [standalone]

#1598490 — Re: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy with strlcpy

FromJulia Lawall <julia.lawall@lip6.fr>
Date2017-03-11 22:40 +0100
SubjectRe: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy with strlcpy
Message-ID<tjWU2-cq-17@gated-at.bofh.it>
In reply to#1598483

On Sun, 12 Mar 2017, SIMRAN SINGHAL wrote:

> On Sun, Mar 12, 2017 at 2:53 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Sun, 12 Mar 2017, simran singhal wrote:
> >
> >> Replace strcpy with strlcpy as strcpy does not check for buffer
> >> overflow.
> >> This is found using Flawfinder.
> >>
> >> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> >> ---
> >>
> >>  v2:
> >>    -Correcting the place of the parenthesis
> >>
> >>  drivers/staging/android/ashmem.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> >> index 7cbad0d..eb2f4ef 100644
> >> --- a/drivers/staging/android/ashmem.c
> >> +++ b/drivers/staging/android/ashmem.c
> >> @@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name)
> >>       if (unlikely(asma->file))
> >>               ret = -EINVAL;
> >>       else
> >> -             strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name);
> >> +             strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name,
> >> +                     sizeof(asma->name + ASHMEM_NAME_PREFIX_LEN));
> >
> > This appears to be the old patch.
> >
> > Actually, looking closer, I don't think this is right at all.  There seems
> > to be a goal of leaving some space at the beginning of asma->name.  So the
> > amount of space available for local_name would be computed using a
> > subtraction, not an addition.
> >
> Julia, By mistake I sent the wrong patch.
> And I am not getting you want to mention which space.

The following is the whole asma->name array.  The | in the middle is the
offset ASHMEM_NAME_PREFIX_LEN.  The xxx characters are in the
ASHMEM_NAME_PREFIX_LEN region.  The space for local_name is only the part
indicates with the ys.  This space is smaller than the size of asma->name.
In your calculation, you are allowing it to be larger.  You will
potentially overflow the buffer by 2 * ASHMEM_NAME_PREFIX_LEN.

     --------------------------
    |xxxxxxx|yyyyyyyyyyyyyyyyyy|
     --------------------------

julia

[toc] | [prev] | [next] | [standalone]

#1598493 — Re: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy with strlcpy

FromSIMRAN SINGHAL <singhalsimran0@gmail.com>
Date2017-03-11 22:40 +0100
SubjectRe: [Outreachy kernel] [PATCH v2] staging: android: Replace strcpy with strlcpy
Message-ID<tjWU2-cq-19@gated-at.bofh.it>
In reply to#1598483
On Sun, Mar 12, 2017 at 2:53 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 12 Mar 2017, simran singhal wrote:
>
>> Replace strcpy with strlcpy as strcpy does not check for buffer
>> overflow.
>> This is found using Flawfinder.
>>
>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
>> ---
>>
>>  v2:
>>    -Correcting the place of the parenthesis
>>
>>  drivers/staging/android/ashmem.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
>> index 7cbad0d..eb2f4ef 100644
>> --- a/drivers/staging/android/ashmem.c
>> +++ b/drivers/staging/android/ashmem.c
>> @@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name)
>>       if (unlikely(asma->file))
>>               ret = -EINVAL;
>>       else
>> -             strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name);
>> +             strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name,
>> +                     sizeof(asma->name + ASHMEM_NAME_PREFIX_LEN));
>
> This appears to be the old patch.
>
> Actually, looking closer, I don't think this is right at all.  There seems
> to be a goal of leaving some space at the beginning of asma->name.  So the
> amount of space available for local_name would be computed using a
> subtraction, not an addition.
>
Julia, By mistake I sent the wrong patch.
And I am not getting you want to mention which space.

> julia
>
>>
>>       mutex_unlock(&ashmem_mutex);
>>       return ret;
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170311211725.GA12884%40singhal-Inspiron-5558.
>> For more options, visit https://groups.google.com/d/optout.
>>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web