Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598337 > unrolled thread
| Started by | simran singhal <singhalsimran0@gmail.com> |
|---|---|
| First post | 2017-03-11 15:30 +0100 |
| Last post | 2017-03-11 19:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v1 06/10] staging: iio: adis16201: Remove exceptional & on function name simran singhal <singhalsimran0@gmail.com> - 2017-03-11 15:30 +0100
Re: [PATCH v1 06/10] staging: iio: adis16201: Remove exceptional & on function name Jonathan Cameron <jic23@kernel.org> - 2017-03-11 19:50 +0100
| From | simran singhal <singhalsimran0@gmail.com> |
|---|---|
| Date | 2017-03-11 15:30 +0100 |
| Subject | [PATCH v1 06/10] staging: iio: adis16201: Remove exceptional & on function name |
| Message-ID | <tjQbT-41k-1@gated-at.bofh.it> |
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/iio/accel/adis16201.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
index d6c8658..7565268 100644
--- a/drivers/staging/iio/accel/adis16201.c
+++ b/drivers/staging/iio/accel/adis16201.c
@@ -285,8 +285,8 @@ static const struct iio_chan_spec adis16201_channels[] = {
};
static const struct iio_info adis16201_info = {
- .read_raw = &adis16201_read_raw,
- .write_raw = &adis16201_write_raw,
+ .read_raw = adis16201_read_raw,
+ .write_raw = adis16201_write_raw,
.update_scan_mode = adis_update_scan_mode,
.driver_module = THIS_MODULE,
};
--
2.7.4
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-03-11 19:50 +0100 |
| Subject | Re: [PATCH v1 06/10] staging: iio: adis16201: Remove exceptional & on function name |
| Message-ID | <tjUfv-6My-19@gated-at.bofh.it> |
| In reply to | #1598337 |
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> // <smpl>
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> // </smpl>
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied.
> ---
> drivers/staging/iio/accel/adis16201.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
> index d6c8658..7565268 100644
> --- a/drivers/staging/iio/accel/adis16201.c
> +++ b/drivers/staging/iio/accel/adis16201.c
> @@ -285,8 +285,8 @@ static const struct iio_chan_spec adis16201_channels[] = {
> };
>
> static const struct iio_info adis16201_info = {
> - .read_raw = &adis16201_read_raw,
> - .write_raw = &adis16201_write_raw,
> + .read_raw = adis16201_read_raw,
> + .write_raw = adis16201_write_raw,
> .update_scan_mode = adis_update_scan_mode,
> .driver_module = THIS_MODULE,
> };
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web