Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598296 > unrolled thread

[PATCH] statx: remove incorrect part of vfs_statx() comment

Back to article view | Back to linux.kernel

Contents

  [PATCH] statx: remove incorrect part of vfs_statx() comment Eric Biggers <ebiggers3@gmail.com> - 2017-03-11 11:20 +0100
    Re: [PATCH] statx: remove incorrect part of vfs_statx() comment David Howells <dhowells@redhat.com> - 2017-03-11 20:30 +0100

#1598296 — [PATCH] statx: remove incorrect part of vfs_statx() comment

From: Eric Biggers <ebiggers@google.com>

request_mask and query_flags are function arguments, not passed in
struct kstat.  So remove the part of the comment which claims otherwise.
This was apparently left over from an earlier version of the statx
patch.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/stat.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/stat.c b/fs/stat.c
index df484a60846d..b792dd201c31 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -159,9 +159,6 @@ EXPORT_SYMBOL(vfs_statx_fd);
  * Additionally, the use of AT_SYMLINK_NOFOLLOW in flags will prevent a symlink
  * at the given name from being referenced.
  *
- * The caller must have preset stat->request_mask as for vfs_getattr().  The
- * flags are also used to load up stat->query_flags.
- *
  * 0 will be returned on success, and a -ve error code if unsuccessful.
  */
 int vfs_statx(int dfd, const char __user *filename, int flags,
-- 
2.12.0

[toc] | [next] | [standalone]

#1598435

Eric Biggers <ebiggers3@gmail.com> wrote:

> From: Eric Biggers <ebiggers@google.com>
> 
> request_mask and query_flags are function arguments, not passed in
> struct kstat.  So remove the part of the comment which claims otherwise.
> This was apparently left over from an earlier version of the statx
> patch.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Acked-by: David Howells <dhowells@redhat.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web