Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598434 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-03-11 20:30 +0100 |
| Last post | 2017-03-12 16:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: cs35l35: trivial fix to indentation Colin King <colin.king@canonical.com> - 2017-03-11 20:30 +0100
Re: [PATCH] ASoC: cs35l35: trivial fix to indentation walter harms <wharms@bfs.de> - 2017-03-12 16:00 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-03-11 20:30 +0100 |
| Subject | [PATCH] ASoC: cs35l35: trivial fix to indentation |
| Message-ID | <tjUSd-7fQ-5@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Remove extraneous tab to correct the nesting level indentation
Detected by CoverityScan, CID#1416584 ("Nesting level does
not match indentation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/codecs/cs35l35.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42..43d33f4 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
- cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
+
+ cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
ret = devm_regulator_bulk_get(&i2c_client->dev,
cs35l35->num_supplies,
--
2.10.2
[toc] | [next] | [standalone]
| From | walter harms <wharms@bfs.de> |
|---|---|
| Date | 2017-03-12 16:00 +0100 |
| Message-ID | <tkd8u-2UH-21@gated-at.bofh.it> |
| In reply to | #1598434 |
Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove extraneous tab to correct the nesting level indentation
>
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/codecs/cs35l35.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>
> for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
> cs35l35->supplies[i].supply = cs35l35_supplies[i];
> - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>
I have the feeling is better before the loop:
cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
for (i = 0; i < cs35l35->num_supplies; i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
re,
wh
> ret = devm_regulator_bulk_get(&i2c_client->dev,
> cs35l35->num_supplies,
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web