Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593277 > unrolled thread

[PATCH] dma: xilinx: Make Xilinx VDMA support ARC

Back to article view | Back to linux.kernel

Contents

  [PATCH] dma: xilinx: Make Xilinx VDMA support ARC Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2017-03-06 13:40 +0100
    Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2017-03-09 11:00 +0100
      Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC Vinod Koul <vinod.koul@intel.com> - 2017-03-10 05:40 +0100
    Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC Mike Looijmans <mike.looijmans@topic.nl> - 2017-03-09 18:00 +0100

#1593277 — [PATCH] dma: xilinx: Make Xilinx VDMA support ARC

Add option in Kconfig to use Xilinx VDMA in ARC processors.

Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 263495d0adbd..b6b6c0581ad7 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -546,7 +546,7 @@ config XGENE_DMA
 
 config XILINX_DMA
 	tristate "Xilinx AXI DMAS Engine"
-	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
+	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)
 	select DMA_ENGINE
 	help
 	  Enable support for Xilinx AXI VDMA Soft IP.
-- 
2.11.0

[toc] | [next] | [standalone]

#1595853

Hi Mike

On 3/9/2017 7:37 AM, Mike Looijmans wrote:
> On 06-03-17 13:27, Ramiro Oliveira wrote:
>> Add option in Kconfig to use Xilinx VDMA in ARC processors.
>>
>> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
>> ---
>>  drivers/dma/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
>> index 263495d0adbd..b6b6c0581ad7 100644
>> --- a/drivers/dma/Kconfig
>> +++ b/drivers/dma/Kconfig
>> @@ -546,7 +546,7 @@ config XGENE_DMA
>>
>>  config XILINX_DMA
>>      tristate "Xilinx AXI DMAS Engine"
>> -    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
>> +    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)
> 
> One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and then
> use it on any platform that supports PCIe.
> 
> I've had to remove this line in order to be able to use the engine on an x86
> desktop.
> 
> How about plainly removing this "depends on" line and be done with it, instead
> of adding platforms one by one?
> 
> 

I agree with you. From my point of view it would be better to remove this line
entirely. I'm just not sure if everyone agrees.

>>      select DMA_ENGINE
>>      help
>>        Enable support for Xilinx AXI VDMA Soft IP.
>>
> 
> 
> 
> Kind regards,
> 
> Mike Looijmans
> System Expert
> 
> TOPIC Products
> Materiaalweg 4, NL-5681 RJ Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> E-mail: mike.looijmans@topicproducts.com
> Website: www.topicproducts.com
> 
> Please consider the environment before printing this e-mail
> 
> 
> 
> 
> 

-- 
Best Regards

Ramiro Oliveira
Ramiro.Oliveira@synopsys.com

[toc] | [prev] | [next] | [standalone]

#1596616

On Thu, Mar 09, 2017 at 09:55:59AM +0000, Ramiro Oliveira wrote:
> Hi Mike
> 
> On 3/9/2017 7:37 AM, Mike Looijmans wrote:
> > On 06-03-17 13:27, Ramiro Oliveira wrote:
> >> Add option in Kconfig to use Xilinx VDMA in ARC processors.
> >>
> >> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> >> ---
> >>  drivers/dma/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> >> index 263495d0adbd..b6b6c0581ad7 100644
> >> --- a/drivers/dma/Kconfig
> >> +++ b/drivers/dma/Kconfig
> >> @@ -546,7 +546,7 @@ config XGENE_DMA
> >>
> >>  config XILINX_DMA
> >>      tristate "Xilinx AXI DMAS Engine"
> >> -    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> >> +    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)
> > 
> > One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and then
> > use it on any platform that supports PCIe.
> > 
> > I've had to remove this line in order to be able to use the engine on an x86
> > desktop.
> > 
> > How about plainly removing this "depends on" line and be done with it, instead
> > of adding platforms one by one?
> > 
> > 
> 
> I agree with you. From my point of view it would be better to remove this line
> entirely. I'm just not sure if everyone agrees.

if it works on others, compiles fine then there should not be an issue to
remove.

Feel free to send the patch.

-- 
~Vinod

[toc] | [prev] | [next] | [standalone]

#1596204

On 06-03-17 13:27, Ramiro Oliveira wrote:
> Add option in Kconfig to use Xilinx VDMA in ARC processors.
>
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 263495d0adbd..b6b6c0581ad7 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -546,7 +546,7 @@ config XGENE_DMA
>
>  config XILINX_DMA
>  	tristate "Xilinx AXI DMAS Engine"
> -	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> +	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)

One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and 
then use it on any platform that supports PCIe.

I've had to remove this line in order to be able to use the engine on an x86 
desktop.

How about plainly removing this "depends on" line and be done with it, instead 
of adding platforms one by one?


>  	select DMA_ENGINE
>  	help
>  	  Enable support for Xilinx AXI VDMA Soft IP.
>



Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web