Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594123 > unrolled thread

[PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells Dave Gerlach <d-gerlach@ti.com> - 2017-03-07 12:10 +0100
    Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells Kevin Hilman <khilman@baylibre.com> - 2017-03-10 22:20 +0100
    Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers  have phandle cells Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-13 09:30 +0100

#1594123 — [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells

<<< No Message Collected >>>

[toc] | [next] | [standalone]

#1598092

Dave Gerlach <d-gerlach@ti.com> writes:

> There is no reason that a platform genpd driver registered using
> of_genpd_add_provider_simple needs to be constrained to having no cells
> in the "power-domains" phandle. Currently the genpd framework will fail
> if any arguments are passed with for a simple provider but the framework
> does not actually care, so remove the check for phandle argument count.
>
> This will allow greater flexibility for genpd providers to use their own
> arguments that are passed in the phandle and interpret them however they
> see fit.
>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
> v3->v4:
>  Drop ti,sci-id device property and instead describe using phandle cell
>  for id.
>
>  drivers/base/power/domain.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index e697dec9d25b..8e0550c27394 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple(
>  					struct of_phandle_args *genpdspec,
>  					void *data)
>  {
> -	if (genpdspec->args_count != 0)
> -		return ERR_PTR(-EINVAL);
>  	return data;
>  }

[toc] | [prev] | [next] | [standalone]

#1598937 — Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells

On 7 March 2017 at 11:22, Dave Gerlach <d-gerlach@ti.com> wrote:
> There is no reason that a platform genpd driver registered using
> of_genpd_add_provider_simple needs to be constrained to having no cells
> in the "power-domains" phandle. Currently the genpd framework will fail
> if any arguments are passed with for a simple provider but the framework
> does not actually care, so remove the check for phandle argument count.
>
> This will allow greater flexibility for genpd providers to use their own
> arguments that are passed in the phandle and interpret them however they
> see fit.
>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

> ---
> v3->v4:
>  Drop ti,sci-id device property and instead describe using phandle cell
>  for id.
>
>  drivers/base/power/domain.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index e697dec9d25b..8e0550c27394 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple(
>                                         struct of_phandle_args *genpdspec,
>                                         void *data)
>  {
> -       if (genpdspec->args_count != 0)
> -               return ERR_PTR(-EINVAL);
>         return data;
>  }
>
> --
> 2.11.0
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web