Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590298 > unrolled thread

[PATCH] ALSA: ASoC: TLV320AIC23: Unquote NULL from control name

Back to article view | Back to linux.kernel

Contents

  [PATCH] ALSA: ASoC: TLV320AIC23: Unquote NULL from control name Liviu Dudau <liviu@dudau.co.uk> - 2017-03-01 13:40 +0100
    Re: [PATCH] ALSA: ASoC: TLV320AIC23: Unquote NULL from control name Mark Brown <broonie@kernel.org> - 2017-03-06 11:50 +0100
      Re: [PATCH] ALSA: ASoC: TLV320AIC23: Unquote NULL from control name Liviu Dudau <liviu@dudau.co.uk> - 2017-03-07 02:00 +0100
        Re: [PATCH] ALSA: ASoC: TLV320AIC23: Unquote NULL from control name Mark Brown <broonie@kernel.org> - 2017-03-07 14:40 +0100

#1590298 — [PATCH] ALSA: ASoC: TLV320AIC23: Unquote NULL from control name

Without this I am getting the following messages at boot on my Trimslice:
   tlv320aic23-codec 2-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input
   tlv320aic23-codec 2-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input
   tlv320aic23-codec 2-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input
   tlv320aic23-codec 2-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input
   tlv320aic23-codec 2-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input
   tlv320aic23-codec 2-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input
   tlv320aic23-codec 2-001a: Control not supported for path MICIN -> [NULL] -> Mic Input
   tlv320aic23-codec 2-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input
   tlv320aic23-codec 2-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input
   tegra-snd-trimslice sound: tlv320aic23-hifi <-> 70002800.i2s mapping ok

Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
---
 sound/soc/codecs/tlv320aic23.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
index 410cae0f2060..628a8eeaab68 100644
--- a/sound/soc/codecs/tlv320aic23.c
+++ b/sound/soc/codecs/tlv320aic23.c
@@ -174,10 +174,9 @@ static const struct snd_soc_dapm_route tlv320aic23_intercon[] = {
 	{"ROUT", NULL, "Output Mixer"},
 
 	/* Inputs */
-	{"Line Input", "NULL", "LLINEIN"},
-	{"Line Input", "NULL", "RLINEIN"},
-
-	{"Mic Input", "NULL", "MICIN"},
+	{"Line Input", NULL, "LLINEIN"},
+	{"Line Input", NULL, "RLINEIN"},
+	{"Mic Input", NULL, "MICIN"},
 
 	/* input mux */
 	{"Capture Source", "Line", "Line Input"},
-- 
2.11.1

[toc] | [next] | [standalone]

#1593187

[Multipart message — attachments visible in raw view] — view raw

On Wed, Mar 01, 2017 at 12:26:28PM +0000, Liviu Dudau wrote:
> Without this I am getting the following messages at boot on my Trimslice:
>    tlv320aic23-codec 2-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.

[toc] | [prev] | [next] | [standalone]

#1593823

Hi Mark,

On Mon, Mar 06, 2017 at 11:41:18AM +0100, Mark Brown wrote:
> On Wed, Mar 01, 2017 at 12:26:28PM +0000, Liviu Dudau wrote:
> > Without this I am getting the following messages at boot on my Trimslice:
> >    tlv320aic23-codec 2-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input
> 
> Please use subject lines matching the style for the subsystem.  This
> makes it easier for people to identify relevant patches.

Other than the additional ALSA: prefix I have matched the format used
by previous commits touching the file. I'm not clear where I have made the
mistake and what would have been the better subject line.

Best regards,
Liviu

[toc] | [prev] | [next] | [standalone]

#1594241

[Multipart message — attachments visible in raw view] — view raw

On Tue, Mar 07, 2017 at 12:54:08AM +0000, Liviu Dudau wrote:
> On Mon, Mar 06, 2017 at 11:41:18AM +0100, Mark Brown wrote:

> > Please use subject lines matching the style for the subsystem.  This
> > makes it easier for people to identify relevant patches.

> Other than the additional ALSA: prefix I have matched the format used
> by previous commits touching the file. I'm not clear where I have made the
> mistake and what would have been the better subject line.

It's the extra ALSA prefix, the start of the subject line is the most
important bit to get right since it's that that people are most likely
to pattern match on.  You also used caps for the name of the CODEC,
normally they use lower case, though that is less important.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web