Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1595302 > unrolled thread

Re: [PATCH 6/6] sysctl: Add global tunable mt_page_copy

Started byAnshuman Khandual <khandual@linux.vnet.ibm.com>
First post2017-03-08 16:50 +0100
Last post2017-03-10 13:50 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 6/6] sysctl: Add global tunable mt_page_copy Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-08 16:50 +0100
    Re: [kbuild-all] [PATCH 6/6] sysctl: Add global tunable mt_page_copy Ye Xiaolong <xiaolong.ye@intel.com> - 2017-03-10 02:20 +0100
      Re: [kbuild-all] [PATCH 6/6] sysctl: Add global tunable mt_page_copy Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-10 13:50 +0100

#1595302 — Re: [PATCH 6/6] sysctl: Add global tunable mt_page_copy

FromAnshuman Khandual <khandual@linux.vnet.ibm.com>
Date2017-03-08 16:50 +0100
SubjectRe: [PATCH 6/6] sysctl: Add global tunable mt_page_copy
Message-ID<tiM0G-86-13@gated-at.bofh.it>
On 02/17/2017 09:00 PM, kbuild test robot wrote:
> Hi Zi,
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.10-rc8 next-20170217]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Anshuman-Khandual/Enable-parallel-page-migration/20170217-200523
> config: i386-randconfig-a0-02131010 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Though I dont have the same compiler, I am unable to reproduce this
build failure exactly. The build fails but for a different symbol.
I have the following gcc version but does it really make a
difference with respect to finding the symbol etc ?

gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2


mm/memory.c: In function ‘copy_pmd_range’:
mm/memory.c:1002:3: error: implicit declaration of function
‘pmd_related’ [-Werror=implicit-function-declaration]
   if (pmd_related(*src_pmd)) {
   ^
cc1: some warnings being treated as errors
scripts/Makefile.build:294: recipe for target 'mm/memory.o' failed

[toc] | [next] | [standalone]


#1596535 — Re: [kbuild-all] [PATCH 6/6] sysctl: Add global tunable mt_page_copy

FromYe Xiaolong <xiaolong.ye@intel.com>
Date2017-03-10 02:20 +0100
SubjectRe: [kbuild-all] [PATCH 6/6] sysctl: Add global tunable mt_page_copy
Message-ID<tjhnQ-4Ms-5@gated-at.bofh.it>
In reply to#1595302
On 03/08, Anshuman Khandual wrote:
>On 02/17/2017 09:00 PM, kbuild test robot wrote:
>> Hi Zi,
>> 
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.10-rc8 next-20170217]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> 
>> url:    https://github.com/0day-ci/linux/commits/Anshuman-Khandual/Enable-parallel-page-migration/20170217-200523
>> config: i386-randconfig-a0-02131010 (attached as .config)
>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>
>Though I dont have the same compiler, I am unable to reproduce this
>build failure exactly. The build fails but for a different symbol.

I think previous "undefined reference to `mt_page_copy'" error is due to kbuild
bot didn't set CONFIG_MIGRATION (see attached config in original mail) since it
is a randconfig test.

Thanks,
Xiaolong

>I have the following gcc version but does it really make a
>difference with respect to finding the symbol etc ?
>
>gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
>
>
>mm/memory.c: In function ‘copy_pmd_range’:
>mm/memory.c:1002:3: error: implicit declaration of function
>‘pmd_related’ [-Werror=implicit-function-declaration]
>   if (pmd_related(*src_pmd)) {
>   ^
>cc1: some warnings being treated as errors
>scripts/Makefile.build:294: recipe for target 'mm/memory.o' failed
>
>_______________________________________________
>kbuild-all mailing list
>kbuild-all@lists.01.org
>https://lists.01.org/mailman/listinfo/kbuild-all

[toc] | [prev] | [next] | [standalone]


#1597415 — Re: [kbuild-all] [PATCH 6/6] sysctl: Add global tunable mt_page_copy

FromAnshuman Khandual <khandual@linux.vnet.ibm.com>
Date2017-03-10 13:50 +0100
SubjectRe: [kbuild-all] [PATCH 6/6] sysctl: Add global tunable mt_page_copy
Message-ID<tjs9z-43z-1@gated-at.bofh.it>
In reply to#1596535
On 03/10/2017 06:42 AM, Ye Xiaolong wrote:
> On 03/08, Anshuman Khandual wrote:
>> On 02/17/2017 09:00 PM, kbuild test robot wrote:
>>> Hi Zi,
>>>
>>> [auto build test ERROR on linus/master]
>>> [also build test ERROR on v4.10-rc8 next-20170217]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/Anshuman-Khandual/Enable-parallel-page-migration/20170217-200523
>>> config: i386-randconfig-a0-02131010 (attached as .config)
>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>> Though I dont have the same compiler, I am unable to reproduce this
>> build failure exactly. The build fails but for a different symbol.
> I think previous "undefined reference to `mt_page_copy'" error is due to kbuild
> bot didn't set CONFIG_MIGRATION (see attached config in original mail) since it
> is a randconfig test.

If CONFIG_MIGRATION is not set then mm/migrate.c never gets compiled
and the symbol 'mt_page_copy' is never exported for kernel/sysctl.c
based extern variable to use. Sure, will fix it by keeping all the
code in kernel/sysctl.c within CONFIG_MIGRATION config. Thanks for
pointing it out.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web