Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595184 > unrolled thread

Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode Tuomas Tynkkynen <tuomas@tuxera.com> - 2017-03-08 14:50 +0100

#1595184 — Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode

On Wed, 22 Feb 2017 02:06:29 +0200
Tuomas Tynkkynen <tuomas@tuxera.com> wrote:

> Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details
> and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked()
> instead of iget_locked(). However, the test() callback is not checking
> fid.path at all, which means that a lookup in the inode cache can now
> accidentally locate a completely wrong inode from the same inode hash
> bucket if the other fields (qid.type and qid.version) match.
> 

Al, does this sound sensible? (or if there is someone else picking up 9p
patches, let me know).

Thanks!

- Tuomas

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web