Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593434 > unrolled thread

[PATCH 0/2] Documentation/EDID fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] Documentation/EDID fixes Javi Merino <javi.merino@kernel.org> - 2017-03-06 15:40 +0100
    [PATCH 2/2] drm: Add O= support Javi Merino <javi.merino@kernel.org> - 2017-03-06 15:50 +0100
    Re: [PATCH 0/2] Documentation/EDID fixes Javi Merino <javi.merino@kernel.org> - 2017-03-07 17:50 +0100
      Re: [PATCH 0/2] Documentation/EDID fixes Jani Nikula <jani.nikula@linux.intel.com> - 2017-03-08 09:20 +0100
    Re: [PATCH 0/2] Documentation/EDID fixes Jani Nikula <jani.nikula@linux.intel.com> - 2017-03-07 21:10 +0100

#1593434 — [PATCH 0/2] Documentation/EDID fixes

Hi,

I found these two minor issues while building an EDID.  I'm not sure
whether the second patch (Add O= to support) is upstream material, but
I'm sending it just in case.

Thanks,
Javi

Javi Merino (2):
  drm: use .hword to represent 16-bit numbers
  drm: Add O= support

 Documentation/EDID/Makefile | 21 ++++++++++++---------
 Documentation/EDID/edid.S   |  6 +++---
 2 files changed, 15 insertions(+), 12 deletions(-)

-- 
2.1.4

[toc] | [next] | [standalone]

#1593456 — [PATCH 2/2] drm: Add O= support

Add an option to put all output files in a given directory, similar to
what kbuild does.

Cc: Carsten Emde <C.Emde@osadl.org>
Cc: David Airlie <airlied@linux.ie>
Signed-off-by: Javi Merino <javi.merino@kernel.org>
---
 Documentation/EDID/Makefile | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/Documentation/EDID/Makefile b/Documentation/EDID/Makefile
index 17763ca..76e8ef5 100644
--- a/Documentation/EDID/Makefile
+++ b/Documentation/EDID/Makefile
@@ -1,26 +1,29 @@
 
+# use "make O=dir" to locate all output files in "dir"
+O ?= .
+
 SOURCES	:= $(wildcard [0-9]*x[0-9]*.S)
 
-BIN	:= $(patsubst %.S, %.bin, $(SOURCES))
+BIN	:= $(patsubst %.S, $(O)/%.bin, $(SOURCES))
 
-IHEX	:= $(patsubst %.S, %.bin.ihex, $(SOURCES))
+IHEX	:= $(patsubst %.S, $(O)/%.bin.ihex, $(SOURCES))
 
-CODE	:= $(patsubst %.S, %.c, $(SOURCES))
+CODE	:= $(patsubst %.S, $(O)/%.c, $(SOURCES))
 
 all:	$(BIN) $(IHEX) $(CODE)
 
 clean:
-	@rm -f *.o *.bin.ihex *.bin *.c
+	@rm -f $(O)/*.o $(O)/*.bin.ihex $(O)/*.bin $(O)/*.c
 
-%.o:	%.S
-	@cc -c $^
+$(O)/%.o:	%.S
+	@cc -c $^ -o $@
 
-%.bin:	%.o
+$(O)/%.bin:	$(O)/%.o
 	@objcopy -Obinary $^ $@
 
-%.bin.ihex:	%.o
+$(O)/%.bin.ihex:	$(O)/%.o
 	@objcopy -Oihex $^ $@
 	@dos2unix $@ 2>/dev/null
 
-%.c:	%.bin
+$(O)/%.c:	$(O)/%.bin
 	@echo "{" >$@; hexdump -f hex $^ >>$@; echo "};" >>$@
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1594422

On Tue, Mar 07, 2017 at 06:16:51PM +0200, Jani Nikula wrote:
> On Mon, 06 Mar 2017, Javi Merino <javi.merino@kernel.org> wrote:
> > I found these two minor issues while building an EDID.  I'm not sure
> > whether the second patch (Add O= to support) is upstream material, but
> > I'm sending it just in case.
> 
> I'm not opposed to fixing existing issues like this, but really I think
> there should be an userspace tool for this. Definitely outside of the
> Documentation directory, perhaps even outside the kernel tree
> altogether.

I am not sure whether this should be in the kernel or not, but I
agree that Documentation/ doesn't look like the right place to build
these files.

Cheers,
Javi

[toc] | [prev] | [next] | [standalone]

#1594922

On Tue, 07 Mar 2017, Javi Merino <javi.merino@kernel.org> wrote:
> On Tue, Mar 07, 2017 at 06:16:51PM +0200, Jani Nikula wrote:
>> On Mon, 06 Mar 2017, Javi Merino <javi.merino@kernel.org> wrote:
>> > I found these two minor issues while building an EDID.  I'm not sure
>> > whether the second patch (Add O= to support) is upstream material, but
>> > I'm sending it just in case.
>> 
>> I'm not opposed to fixing existing issues like this, but really I think
>> there should be an userspace tool for this. Definitely outside of the
>> Documentation directory, perhaps even outside the kernel tree
>> altogether.
>
> I am not sure whether this should be in the kernel or not, but I
> agree that Documentation/ doesn't look like the right place to build
> these files.

Just so there's no confusion: I'm just saying what I think should be
done in the long run. I'm not opposed to the fixes at hand, but someone
else needs to review them.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1594600

On Mon, 06 Mar 2017, Javi Merino <javi.merino@kernel.org> wrote:
> I found these two minor issues while building an EDID.  I'm not sure
> whether the second patch (Add O= to support) is upstream material, but
> I'm sending it just in case.

I'm not opposed to fixing existing issues like this, but really I think
there should be an userspace tool for this. Definitely outside of the
Documentation directory, perhaps even outside the kernel tree
altogether.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web