Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594841 > unrolled thread

[PATCH] don't forget to call pd_online_fn when activate policy

Back to article view | Back to linux.kernel

Contents

  [PATCH] don't forget to call pd_online_fn when activate policy Zhou Chengming <zhouchengming1@huawei.com> - 2017-03-08 05:20 +0100
    Re: [PATCH] don't forget to call pd_online_fn when activate policy Jens Axboe <axboe@kernel.dk> - 2017-03-08 23:20 +0100

#1594841 — [PATCH] don't forget to call pd_online_fn when activate policy

From: z00354408 <z00354408@notesmail.huawei.com>

Signed-off-by: z00354408 <z00354408@notesmail.huawei.com>
---
 block/blk-cgroup.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 8ba0af7..0dd9e76 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1254,6 +1254,12 @@ int blkcg_activate_policy(struct request_queue *q,
 		pd->plid = pol->plid;
 		if (pol->pd_init_fn)
 			pol->pd_init_fn(pd);
+
+		if (pol->pd_online_fn) {
+			spin_lock(blkg->blkcg->lock);
+			pol->pd_online_fn(pd);
+			spin_unlock(blkg->blkcg->lock);
+		}
 	}
 
 	__set_bit(pol->plid, q->blkcg_pols);
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1595556

On 03/07/2017 09:09 PM, Zhou Chengming wrote:
> From: z00354408 <z00354408@notesmail.huawei.com>

The patch looks correct to me, but please provide a better
changelog for the change. There's nothing here.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web