Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1591211 > unrolled thread
| Started by | Georgios Emmanouil <geo.emmnl@gmail.com> |
|---|---|
| First post | 2017-03-02 16:50 +0100 |
| Last post | 2017-03-05 00:00 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis Georgios Emmanouil <geo.emmnl@gmail.com> - 2017-03-02 16:50 +0100
[PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement Georgios Emmanouil <geo.emmnl@gmail.com> - 2017-03-02 18:00 +0100
Re: [PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement Julian Calaby <julian.calaby@gmail.com> - 2017-03-05 00:00 +0100
Re: [PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis Julian Calaby <julian.calaby@gmail.com> - 2017-03-05 00:00 +0100
| From | Georgios Emmanouil <geo.emmnl@gmail.com> |
|---|---|
| Date | 2017-03-02 16:50 +0100 |
| Subject | [PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis |
| Message-ID | <tgB9o-4qi-23@gated-at.bofh.it> |
Fixed alignment to match open parenthesis.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 090fd43..bbe1a09 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1349,7 +1349,7 @@ static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
if (u32RcvdAssocRespInfoLen != 0) {
s32Err = wilc_parse_assoc_resp_info(rcv_assoc_resp, u32RcvdAssocRespInfoLen,
- &pstrConnectRespInfo);
+ &pstrConnectRespInfo);
if (s32Err) {
netdev_err(vif->ndev, "wilc_parse_assoc_resp_info() returned error %d\n", s32Err);
} else {
--
2.1.4
[toc] | [next] | [standalone]
| From | Georgios Emmanouil <geo.emmnl@gmail.com> |
|---|---|
| Date | 2017-03-02 18:00 +0100 |
| Subject | [PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement |
| Message-ID | <tgCf7-56J-19@gated-at.bofh.it> |
| In reply to | #1591211 |
Removed unnecessary 'if' statement and integrated the condition to the
previous 'if' statement.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index bbe1a09..4936e80 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1355,13 +1355,11 @@ static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
} else {
strConnectInfo.status = pstrConnectRespInfo->status;
- if (strConnectInfo.status == SUCCESSFUL_STATUSCODE) {
- if (pstrConnectRespInfo->ies) {
- strConnectInfo.resp_ies_len = pstrConnectRespInfo->ies_len;
- strConnectInfo.resp_ies = kmalloc(pstrConnectRespInfo->ies_len, GFP_KERNEL);
- memcpy(strConnectInfo.resp_ies, pstrConnectRespInfo->ies,
- pstrConnectRespInfo->ies_len);
- }
+ if (strConnectInfo.status == SUCCESSFUL_STATUSCODE && pstrConnectRespInfo->ies) {
+ strConnectInfo.resp_ies_len = pstrConnectRespInfo->ies_len;
+ strConnectInfo.resp_ies = kmalloc(pstrConnectRespInfo->ies_len, GFP_KERNEL);
+ memcpy(strConnectInfo.resp_ies, pstrConnectRespInfo->ies,
+ pstrConnectRespInfo->ies_len);
}
if (pstrConnectRespInfo) {
--
2.1.4
[toc] | [prev] | [next] | [standalone]
| From | Julian Calaby <julian.calaby@gmail.com> |
|---|---|
| Date | 2017-03-05 00:00 +0100 |
| Subject | Re: [PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement |
| Message-ID | <thqOB-7El-3@gated-at.bofh.it> |
| In reply to | #1591283 |
Hi All, On Fri, Mar 3, 2017 at 2:38 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote: > Removed unnecessary 'if' statement and integrated the condition to the > previous 'if' statement. > > Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com> Reviewed-by: Julian Calaby <julian.calaby@gmail.com> > --- > drivers/staging/wilc1000/host_interface.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
[toc] | [prev] | [next] | [standalone]
| From | Julian Calaby <julian.calaby@gmail.com> |
|---|---|
| Date | 2017-03-05 00:00 +0100 |
| Subject | Re: [PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis |
| Message-ID | <thqOB-7El-9@gated-at.bofh.it> |
| In reply to | #1591211 |
Hi All, On Fri, Mar 3, 2017 at 2:37 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote: > Fixed alignment to match open parenthesis. > > Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com> Reviewed-by: Julian Calaby <julian.calaby@gmail.com> > --- > drivers/staging/wilc1000/host_interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web