Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592337 > unrolled thread

[PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list

Started byPali Rohár <pali.rohar@gmail.com>
First post2017-03-04 00:20 +0100
Last post2017-03-09 03:10 +0100
Articles 7 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list Pali Rohár <pali.rohar@gmail.com> - 2017-03-04 00:20 +0100
    Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-04 18:50 +0100
      Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list Vasile Dumitrescu <vasile.dumitrescu@undeva.eu> - 2017-03-04 23:00 +0100
        Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list Jean Delvare <jdelvare@suse.de> - 2017-03-06 12:40 +0100
          Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list Vasile Dumitrescu <vasile.dumitrescu@undeva.eu> - 2017-03-08 20:30 +0100
            Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list Jean Delvare <jdelvare@suse.de> - 2017-03-09 00:20 +0100
    Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list Guenter Roeck <linux@roeck-us.net> - 2017-03-09 03:10 +0100

#1592337 — [PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list

FromPali Rohár <pali.rohar@gmail.com>
Date2017-03-04 00:20 +0100
Subject[PATCH] hwmon: (dell-smm) Add Dell XPS 15 9560 into DMI list
Message-ID<th4Ep-8eD-5@gated-at.bofh.it>
It was reported that dell-smm-hwmon is working fine on Dell XPS 15 9560.

Link: http://www.spinics.net/lists/platform-driver-x86/msg10751.html
Reported-by: Vasile Dumitrescu <vasile.dumitrescu@undeva.eu>
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 drivers/hwmon/dell-smm-hwmon.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 34704b0..3189246 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -995,6 +995,13 @@ enum i8k_configs {
 		},
 		.driver_data = (void *)&i8k_config_data[DELL_XPS],
 	},
+	{
+		.ident = "Dell XPS 15 9560",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"),
+		},
+	},
 	{ }
 };
 
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1592596

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-03-04 18:50 +0100
Message-ID<thlYC-4gH-19@gated-at.bofh.it>
In reply to#1592337
On Sat, Mar 4, 2017 at 12:41 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> It was reported that dell-smm-hwmon is working fine on Dell XPS 15 9560.
>
> Link: http://www.spinics.net/lists/platform-driver-x86/msg10751.html
> Reported-by: Vasile Dumitrescu <vasile.dumitrescu@undeva.eu>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---

Vasile, can you test this fix?

>  drivers/hwmon/dell-smm-hwmon.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 34704b0..3189246 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -995,6 +995,13 @@ enum i8k_configs {
>                 },
>                 .driver_data = (void *)&i8k_config_data[DELL_XPS],
>         },
> +       {
> +               .ident = "Dell XPS 15 9560",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"),
> +               },
> +       },
>         { }
>  };
>
> --
> 1.7.9.5
>



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1592621

FromVasile Dumitrescu <vasile.dumitrescu@undeva.eu>
Date2017-03-04 23:00 +0100
Message-ID<thpSx-71b-15@gated-at.bofh.it>
In reply to#1592596
ok, but how? I am on Debian,  and I never in my life compiled a kernel...

What would I need to do?

On 4 March 2017 at 18:44, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sat, Mar 4, 2017 at 12:41 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
>> It was reported that dell-smm-hwmon is working fine on Dell XPS 15 9560.
>>
>> Link: http://www.spinics.net/lists/platform-driver-x86/msg10751.html
>> Reported-by: Vasile Dumitrescu <vasile.dumitrescu@undeva.eu>
>> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>> ---
>
> Vasile, can you test this fix?
>
>>  drivers/hwmon/dell-smm-hwmon.c |    7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>> index 34704b0..3189246 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -995,6 +995,13 @@ enum i8k_configs {
>>                 },
>>                 .driver_data = (void *)&i8k_config_data[DELL_XPS],
>>         },
>> +       {
>> +               .ident = "Dell XPS 15 9560",
>> +               .matches = {
>> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"),
>> +               },
>> +       },
>>         { }
>>  };
>>
>> --
>> 1.7.9.5
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1593232

FromJean Delvare <jdelvare@suse.de>
Date2017-03-06 12:40 +0100
Message-ID<thZ9F-7yu-13@gated-at.bofh.it>
In reply to#1592621
Hi Vasile,

On Sat, 4 Mar 2017 22:58:26 +0100, Vasile Dumitrescu wrote:
> ok, but how? I am on Debian,  and I never in my life compiled a kernel...
> 
> What would I need to do?

If your Debian system has a kernel >= 3.13 and you are somewhat
familiar with compiling from sources, you could give a try to this
standalone driver:

http://jdelvare.nerim.net/devel/lm-sensors/drivers/dell-smm-hwmon/

Instructions are at:

http://jdelvare.nerim.net/devel/lm-sensors/drivers/INSTALL

-- 
Jean Delvare
SUSE L3 Support

[toc] | [prev] | [next] | [standalone]

#1595462

FromVasile Dumitrescu <vasile.dumitrescu@undeva.eu>
Date2017-03-08 20:30 +0100
Message-ID<tiPrA-2uR-7@gated-at.bofh.it>
In reply to#1593232
Wow, that was easy :-).

so I did:
download the driver source and makefile
make
=> several new files show up including a .ko - WOHOOO
sudo rmmod dell-smm-hwmon
lsmod | grep hwmo
=> nothing
sudo insmod ./dell-smm-hwmon.ko
=> nothing
lsmod | grep hwmo
=> dell_smm_hwmon         16384  0

sudo sensors
=>
coretemp-isa-0000
Adapter: ISA adapter
Physical id 0:  +50.0°C  (high = +100.0°C, crit = +100.0°C)
Core 0:         +47.0°C  (high = +100.0°C, crit = +100.0°C)
Core 1:         +50.0°C  (high = +100.0°C, crit = +100.0°C)
Core 2:         +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 3:         +48.0°C  (high = +100.0°C, crit = +100.0°C)

acpitz-virtual-0
Adapter: Virtual device
temp1:        +25.0°C  (crit = +107.0°C)

dell_smm-virtual-0
Adapter: Virtual device
Processor Fan: 2490 RPM
Video Fan:     2493 RPM
CPU:            +48.0°C
Ambient:        +48.0°C
Ambient:        +44.0°C
Other:          +40.0°C

sudo pwmconfig
=> fans definitely stop and restart as the script indicates they should

Conclusion: works for me (TM) - without force or any special options

Thanks Jean, that was easy.

Looking forward to see it in some future kernel.

Kind regards

[toc] | [prev] | [next] | [standalone]

#1595575

FromJean Delvare <jdelvare@suse.de>
Date2017-03-09 00:20 +0100
Message-ID<tiT2a-4ZD-9@gated-at.bofh.it>
In reply to#1595462
On Wed, 8 Mar 2017 20:25:33 +0100, Vasile Dumitrescu wrote:
> sudo sensors
> =>

Note that you don't need to be root to run "sensors".

> (...)
> dell_smm-virtual-0
> Adapter: Virtual device
> Processor Fan: 2490 RPM
> Video Fan:     2493 RPM
> CPU:            +48.0°C
> Ambient:        +48.0°C
> Ambient:        +44.0°C
> Other:          +40.0°C
> 
> sudo pwmconfig
> => fans definitely stop and restart as the script indicates they should
> 
> Conclusion: works for me (TM) - without force or any special options
> 
> Thanks Jean, that was easy.

You're welcome, glad I could help :-)

> Looking forward to see it in some future kernel.

-- 
Jean Delvare
SUSE L3 Support

[toc] | [prev] | [next] | [standalone]

#1595633

FromGuenter Roeck <linux@roeck-us.net>
Date2017-03-09 03:10 +0100
Message-ID<tiVGG-6MF-3@gated-at.bofh.it>
In reply to#1592337
On 03/03/2017 02:41 PM, Pali Rohár wrote:
> It was reported that dell-smm-hwmon is working fine on Dell XPS 15 9560.
>
> Link: http://www.spinics.net/lists/platform-driver-x86/msg10751.html
> Reported-by: Vasile Dumitrescu <vasile.dumitrescu@undeva.eu>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>

With Vasile's feedback, I'll consider this patch tested and will apply it
to hwmon-next.

Thanks,
Guenter


> ---
>  drivers/hwmon/dell-smm-hwmon.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 34704b0..3189246 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -995,6 +995,13 @@ enum i8k_configs {
>  		},
>  		.driver_data = (void *)&i8k_config_data[DELL_XPS],
>  	},
> +	{
> +		.ident = "Dell XPS 15 9560",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"),
> +		},
> +	},
>  	{ }
>  };
>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web