Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1591268 > unrolled thread

Re: [PATCH 2/2] dt-bindings: display: imx: entry for LAUSCR

Started byRob Herring <robh@kernel.org>
First post2017-03-02 17:50 +0100
Last post2017-03-04 10:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 2/2] dt-bindings: display: imx: entry for LAUSCR Rob Herring <robh@kernel.org> - 2017-03-02 17:50 +0100
    Re: [PATCH 2/2] dt-bindings: display: imx: entry for LAUSCR Martin Kaiser <martin@kaiser.cx> - 2017-03-04 10:40 +0100

#1591268 — Re: [PATCH 2/2] dt-bindings: display: imx: entry for LAUSCR

FromRob Herring <robh@kernel.org>
Date2017-03-02 17:50 +0100
SubjectRe: [PATCH 2/2] dt-bindings: display: imx: entry for LAUSCR
Message-ID<tgC5s-53e-13@gated-at.bofh.it>
On Mon, Feb 27, 2017 at 11:56:42AM +0100, Martin Kaiser wrote:
> Allow setting the LCDC AUS Mode Control Register from the device tree.
> This setting is optional, the register is available only on imx21 and
> compatible chipsets.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> index 7a5c0e2..bd5077f 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> @@ -13,6 +13,8 @@ Required nodes:
>  	Additional, the display node has to define properties:
>  	- bits-per-pixel: Bits per pixel
>  	- fsl,pcr: LCDC PCR value
> +	A display node may optionally define
> +	- fsl,lauscr: LCDC AUS Mode Control Register value (only for imx21)

Looks like we already got one, but generally we don't just put magic 
register values in the DT. What does this register control?

[toc] | [next] | [standalone]


#1592437

FromMartin Kaiser <martin@kaiser.cx>
Date2017-03-04 10:40 +0100
Message-ID<thekp-70D-1@gated-at.bofh.it>
In reply to#1591268
Hi,

Thus wrote Rob Herring (robh@kernel.org):

> On Mon, Feb 27, 2017 at 11:56:42AM +0100, Martin Kaiser wrote:

> >  	- fsl,pcr: LCDC PCR value
> > +	A display node may optionally define
> > +	- fsl,lauscr: LCDC AUS Mode Control Register value (only for imx21)

> Looks like we already got one, but generally we don't just put magic 
> register values in the DT. What does this register control?

it contains settings related to AUS mode. This mode sets different
mappings between framebuffer memory and display pixels. It seems that
these mappings were originally defined for displays from AUO.

The only bit from this register that I really need is "AUS mode on/off".
I could put this into the device tree instead of the entire register.

Best regards,
Martin

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web