Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591702 > unrolled thread

Re: [PATCH v2] video: fbdev: imxfb: support AUS mode

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] video: fbdev: imxfb: support AUS mode Rob Herring <robh@kernel.org> - 2017-03-03 08:00 +0100
    Re: [PATCH v2] video: fbdev: imxfb: support AUS mode Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-03 10:00 +0100
      Re: [PATCH v2] video: fbdev: imxfb: support AUS mode Martin Kaiser <martin@kaiser.cx> - 2017-03-04 09:40 +0100

#1591702 — Re: [PATCH v2] video: fbdev: imxfb: support AUS mode

On Tue, Feb 28, 2017 at 09:04:16PM +0100, Martin Kaiser wrote:
> Some displays require setting AUS mode in the LDCD AUS Mode Control
> Register to work with the imxfb driver. Like the value of the Panel
> Configuration Register, the AUS Mode Control Register's value depends on
> the display mode.
> 
> Allow setting this register from the device tree. Make the device tree
> node optional to keep the DT ABI stable. This register is available only
> on imx21 and compatible chipsets. Update the device tree bindings with
> this info.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> v2:
>   re-sending DT bindings and code changes as one patch

The opposite is what is prefered.

> 
>  .../devicetree/bindings/display/imx/fsl,imx-fb.txt    |  2 ++
>  drivers/video/fbdev/imxfb.c                           | 19 +++++++++++++++++++
>  include/linux/platform_data/video-imxfb.h             |  1 +
>  3 files changed, 22 insertions(+)

[toc] | [next] | [standalone]

#1591752

Hi,

On Friday, March 03, 2017 12:21:30 AM Rob Herring wrote:
> On Tue, Feb 28, 2017 at 09:04:16PM +0100, Martin Kaiser wrote:
> > Some displays require setting AUS mode in the LDCD AUS Mode Control
> > Register to work with the imxfb driver. Like the value of the Panel
> > Configuration Register, the AUS Mode Control Register's value depends on
> > the display mode.
> > 
> > Allow setting this register from the device tree. Make the device tree
> > node optional to keep the DT ABI stable. This register is available only
> > on imx21 and compatible chipsets. Update the device tree bindings with
> > this info.
> > 
> > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> > ---
> > v2:
> >   re-sending DT bindings and code changes as one patch
> 
> The opposite is what is prefered.

Do you mean that you want to have code adding bindings
and its documentation in separate patches (because that
is like it was before)?  This doesn't sound good for me
from kernel changes integrity POV but if this is what
you prefer I can live with that. ;)

> >  .../devicetree/bindings/display/imx/fsl,imx-fb.txt    |  2 ++
> >  drivers/video/fbdev/imxfb.c                           | 19 +++++++++++++++++++
> >  include/linux/platform_data/video-imxfb.h             |  1 +
> >  3 files changed, 22 insertions(+)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1592427

Hi,

Thus wrote Bartlomiej Zolnierkiewicz (b.zolnierkie@samsung.com):

> Do you mean that you want to have code adding bindings
> and its documentation in separate patches (because that
> is like it was before)?

ok, I'll send the next version as two patches again. Looks like we'll
need another iteration anyway.

Best regards,
Martin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web