Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1592870 > unrolled thread
| Started by | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| First post | 2017-03-06 02:10 +0100 |
| Last post | 2017-03-07 11:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] avr32: Fix build error caused by include file reshuffling Guenter Roeck <linux@roeck-us.net> - 2017-03-06 02:10 +0100
Re: [PATCH] avr32: Fix build error caused by include file reshuffling Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2017-03-06 08:20 +0100
[tip:core/urgent] avr32: Fix build error caused by include file reshuffling tip-bot for Guenter Roeck <tipbot@zytor.com> - 2017-03-07 11:00 +0100
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-03-06 02:10 +0100 |
| Subject | [PATCH] avr32: Fix build error caused by include file reshuffling |
| Message-ID | <thPjX-kX-1@gated-at.bofh.it> |
Various avr32 builds fail as follows.
arch/avr32/oprofile/backtrace.c:58: error:
dereferencing pointer to incomplete type
arch/avr32/oprofile/backtrace.c:60: error:
implicit declaration of function 'user_mode'
Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Please feel free to ignore if av32 is going to be removed.
arch/avr32/oprofile/backtrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
index 75d9ad6f99cf..29cf2f191bfd 100644
--- a/arch/avr32/oprofile/backtrace.c
+++ b/arch/avr32/oprofile/backtrace.c
@@ -14,7 +14,7 @@
*/
#include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
#include <linux/uaccess.h>
/* The first two words of each frame on the stack look like this if we have
--
2.7.4
[toc] | [next] | [standalone]
| From | Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> |
|---|---|
| Date | 2017-03-06 08:20 +0100 |
| Message-ID | <thV62-4pW-21@gated-at.bofh.it> |
| In reply to | #1592870 |
Around Sun 05 Mar 2017 17:05:57 -0800 or thereabout, Guenter Roeck wrote:
> Various avr32 builds fail as follows.
>
> arch/avr32/oprofile/backtrace.c:58: error:
> dereferencing pointer to incomplete type
> arch/avr32/oprofile/backtrace.c:60: error:
> implicit declaration of function 'user_mode'
>
> Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
> ---
> Please feel free to ignore if av32 is going to be removed.
AVR32 is not going away for 4.11, we started the FYI and review process too
late to make the window.
I think I will push it, to make sure AVR32 leaves the kernel in as good state
as possible.
> arch/avr32/oprofile/backtrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
> index 75d9ad6f99cf..29cf2f191bfd 100644
> --- a/arch/avr32/oprofile/backtrace.c
> +++ b/arch/avr32/oprofile/backtrace.c
> @@ -14,7 +14,7 @@
> */
>
> #include <linux/oprofile.h>
> -#include <linux/sched.h>
> +#include <linux/ptrace.h>
> #include <linux/uaccess.h>
>
> /* The first two words of each frame on the stack look like this if we have
--
mvh
Hans-Christian Noren Egtvedt
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Guenter Roeck <tipbot@zytor.com> |
|---|---|
| Date | 2017-03-07 11:00 +0100 |
| Subject | [tip:core/urgent] avr32: Fix build error caused by include file reshuffling |
| Message-ID | <tik4p-5CJ-19@gated-at.bofh.it> |
| In reply to | #1592870 |
Commit-ID: 1fbdbcea80056acfc8c8506594744f5ec52208c1
Gitweb: http://git.kernel.org/tip/1fbdbcea80056acfc8c8506594744f5ec52208c1
Author: Guenter Roeck <linux@roeck-us.net>
AuthorDate: Sun, 5 Mar 2017 17:05:57 -0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 7 Mar 2017 08:35:48 +0100
avr32: Fix build error caused by include file reshuffling
Various avr32 builds fail:
arch/avr32/oprofile/backtrace.c:58: error: dereferencing pointer to incomplete type
arch/avr32/oprofile/backtrace.c:60: error: implicit declaration of function 'user_mode'
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <rric@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: oprofile-list@lists.sf.net
Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
Link: http://lkml.kernel.org/r/1488762357-4500-1-git-send-email-linux@roeck-us.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/avr32/oprofile/backtrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
index 75d9ad6..29cf2f1 100644
--- a/arch/avr32/oprofile/backtrace.c
+++ b/arch/avr32/oprofile/backtrace.c
@@ -14,7 +14,7 @@
*/
#include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
#include <linux/uaccess.h>
/* The first two words of each frame on the stack look like this if we have
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web