Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591544 > unrolled thread

Re: [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing llist API

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing  llist API Byungchul Park <byungchul.park@lge.com> - 2017-03-03 00:20 +0100
    Re: [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing  llist API Jiri Kosina <jikos@kernel.org> - 2017-03-05 21:10 +0100
      Re: [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing  llist API Byungchul Park <byungchul.park@lge.com> - 2017-03-06 00:00 +0100

#1591544 — Re: [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing llist API

On Tue, Feb 14, 2017 at 04:26:23PM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.

+ koverstreet@google.com
+ jkosina@suse.cz

I am not sure who I should cc for this subsystem..
Could you check this patch?

Thanks,
Byungchul

> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  drivers/md/bcache/closure.c | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
> index 864e673..1841d03 100644
> --- a/drivers/md/bcache/closure.c
> +++ b/drivers/md/bcache/closure.c
> @@ -64,27 +64,16 @@ void closure_put(struct closure *cl)
>  void __closure_wake_up(struct closure_waitlist *wait_list)
>  {
>  	struct llist_node *list;
> -	struct closure *cl;
> +	struct closure *cl, *t;
>  	struct llist_node *reverse = NULL;
>  
>  	list = llist_del_all(&wait_list->list);
>  
>  	/* We first reverse the list to preserve FIFO ordering and fairness */
> -
> -	while (list) {
> -		struct llist_node *t = list;
> -		list = llist_next(list);
> -
> -		t->next = reverse;
> -		reverse = t;
> -	}
> +	reverse = llist_reverse_order(list);
>  
>  	/* Then do the wakeups */
> -
> -	while (reverse) {
> -		cl = container_of(reverse, struct closure, list);
> -		reverse = llist_next(reverse);
> -
> +	llist_for_each_entry_safe(cl, t, reverse, list) {
>  		closure_set_waiting(cl, 0);
>  		closure_sub(cl, CLOSURE_WAITING + 1);
>  	}
> -- 
> 1.9.1

[toc] | [next] | [standalone]

#1592833

On Fri, 3 Mar 2017, Byungchul Park wrote:

> On Tue, Feb 14, 2017 at 04:26:23PM +0900, Byungchul Park wrote:
> > Although llist provides proper APIs, they are not used. Make them used.
> 
> + koverstreet@google.com
> + jkosina@suse.cz
> 
> I am not sure who I should cc for this subsystem..
> Could you check this patch?

I'd suggest to send it directly to Jens Axboe.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1592856

On Sun, Mar 05, 2017 at 08:59:48PM +0100, Jiri Kosina wrote:
> On Fri, 3 Mar 2017, Byungchul Park wrote:
> 
> > On Tue, Feb 14, 2017 at 04:26:23PM +0900, Byungchul Park wrote:
> > > Although llist provides proper APIs, they are not used. Make them used.
> > 
> > + koverstreet@google.com
> > + jkosina@suse.cz
> > 
> > I am not sure who I should cc for this subsystem..
> > Could you check this patch?
> 
> I'd suggest to send it directly to Jens Axboe.

I'll try it. Thank you very much.

> 
> -- 
> Jiri Kosina
> SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web