Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590702 > unrolled thread
| Started by | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| First post | 2017-03-02 00:50 +0100 |
| Last post | 2017-03-05 15:10 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-02 00:50 +0100
Re: [PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups Jonathan Cameron <jic23@kernel.org> - 2017-03-05 12:30 +0100
Re: [PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups Linus Walleij <linus.walleij@linaro.org> - 2017-03-05 14:00 +0100
Re: [PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups Jonathan Cameron <jic23@kernel.org> - 2017-03-05 15:10 +0100
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-03-02 00:50 +0100 |
| Subject | [PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups |
| Message-ID | <tgmal-1Yy-7@gated-at.bofh.it> |
Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/iio/magnetometer/ak8974.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
index ce09d771c1fb..75f83424903b 100644
--- a/drivers/iio/magnetometer/ak8974.c
+++ b/drivers/iio/magnetometer/ak8974.c
@@ -767,7 +767,7 @@ static int ak8974_probe(struct i2c_client *i2c,
return ret;
}
-static int __exit ak8974_remove(struct i2c_client *i2c)
+static int ak8974_remove(struct i2c_client *i2c)
{
struct iio_dev *indio_dev = i2c_get_clientdata(i2c);
struct ak8974 *ak8974 = iio_priv(indio_dev);
@@ -849,7 +849,7 @@ static struct i2c_driver ak8974_driver = {
.of_match_table = of_match_ptr(ak8974_of_match),
},
.probe = ak8974_probe,
- .remove = __exit_p(ak8974_remove),
+ .remove = ak8974_remove,
.id_table = ak8974_id,
};
module_i2c_driver(ak8974_driver);
--
2.12.0.rc1.440.g5b76565f74-goog
--
Dmitry
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-03-05 12:30 +0100 |
| Subject | Re: [PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups |
| Message-ID | <thCwq-7VQ-17@gated-at.bofh.it> |
| In reply to | #1590702 |
On 01/03/17 23:37, Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, devices can be unbound from the
> driver via sysfs, so we should not be using __exit annotations on
> remove() methods. The only exception is drivers registered with
> platform_driver_probe() which specifically disables sysfs bind/unbind
> attributes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks,
Applied to the fixes-togreg branch of iio.git and marked for stable.
Jonathan
> ---
> drivers/iio/magnetometer/ak8974.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
> index ce09d771c1fb..75f83424903b 100644
> --- a/drivers/iio/magnetometer/ak8974.c
> +++ b/drivers/iio/magnetometer/ak8974.c
> @@ -767,7 +767,7 @@ static int ak8974_probe(struct i2c_client *i2c,
> return ret;
> }
>
> -static int __exit ak8974_remove(struct i2c_client *i2c)
> +static int ak8974_remove(struct i2c_client *i2c)
> {
> struct iio_dev *indio_dev = i2c_get_clientdata(i2c);
> struct ak8974 *ak8974 = iio_priv(indio_dev);
> @@ -849,7 +849,7 @@ static struct i2c_driver ak8974_driver = {
> .of_match_table = of_match_ptr(ak8974_of_match),
> },
> .probe = ak8974_probe,
> - .remove = __exit_p(ak8974_remove),
> + .remove = ak8974_remove,
> .id_table = ak8974_id,
> };
> module_i2c_driver(ak8974_driver);
>
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-03-05 14:00 +0100 |
| Message-ID | <thDVv-py-3@gated-at.bofh.it> |
| In reply to | #1590702 |
On Thu, Mar 2, 2017 at 12:37 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > Even if bus is not hot-pluggable, devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thanks! Linus Walleij
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-03-05 15:10 +0100 |
| Subject | Re: [PATCH] iio: magnetometer: ak8974: remove incorrect __exit markups |
| Message-ID | <thF1f-1s1-7@gated-at.bofh.it> |
| In reply to | #1592758 |
On 05/03/17 12:57, Linus Walleij wrote: > On Thu, Mar 2, 2017 at 12:37 AM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > >> Even if bus is not hot-pluggable, devices can be unbound from the >> driver via sysfs, so we should not be using __exit annotations on >> remove() methods. The only exception is drivers registered with >> platform_driver_probe() which specifically disables sysfs bind/unbind >> attributes. >> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Added. > > Thanks! > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web