Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1592359 > unrolled thread
| Started by | NeilBrown <neil@brown.name> |
|---|---|
| First post | 2017-03-04 01:30 +0100 |
| Last post | 2017-03-04 02:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH v1 29/30] fs: track whether the i_version has been queried with an i_state flag NeilBrown <neil@brown.name> - 2017-03-04 01:30 +0100
Re: [RFC PATCH v1 29/30] fs: track whether the i_version has been queried with an i_state flag Jeff Layton <jlayton@redhat.com> - 2017-03-04 02:00 +0100
| From | NeilBrown <neil@brown.name> |
|---|---|
| Date | 2017-03-04 01:30 +0100 |
| Subject | Re: [RFC PATCH v1 29/30] fs: track whether the i_version has been queried with an i_state flag |
| Message-ID | <th5K9-wg-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Dec 21 2016, Jeff Layton wrote:
> @@ -2072,7 +2093,12 @@ inode_cmp_iversion(const struct inode *inode, const u64 old)
> static inline bool
> inode_iversion_need_inc(struct inode *inode)
> {
> - return true;
> + bool ret;
> +
> + spin_lock(&inode->i_lock);
> + ret = inode->i_state & I_VERS_BUMP;
> + spin_unlock(&inode->i_lock);
> + return ret;
> }
>
I know this code gets removed, so this isn't really important.
By why do you take the spinlock here? What are you racing again?
Thanks,
NeilBrown
[toc] | [next] | [standalone]
| From | Jeff Layton <jlayton@redhat.com> |
|---|---|
| Date | 2017-03-04 02:00 +0100 |
| Subject | Re: [RFC PATCH v1 29/30] fs: track whether the i_version has been queried with an i_state flag |
| Message-ID | <th6dc-Gi-3@gated-at.bofh.it> |
| In reply to | #1592359 |
On Sat, 2017-03-04 at 11:03 +1100, NeilBrown wrote:
> On Wed, Dec 21 2016, Jeff Layton wrote:
>
> > @@ -2072,7 +2093,12 @@ inode_cmp_iversion(const struct inode *inode, const u64 old)
> > static inline bool
> > inode_iversion_need_inc(struct inode *inode)
> > {
> > - return true;
> > + bool ret;
> > +
> > + spin_lock(&inode->i_lock);
> > + ret = inode->i_state & I_VERS_BUMP;
> > + spin_unlock(&inode->i_lock);
> > + return ret;
> > }
> >
>
> I know this code gets removed, so this isn't really important.
> By why do you take the spinlock here? What are you racing again?
>
> Thanks,
> NeilBrown
I think I was worried about I_VERS_BUMP being set or cleared during an
increment or query. It is quite possible that that spinlock is not
necessary.
--
Jeff Layton <jlayton@redhat.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web