Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1591907 > unrolled thread

[PATCH 0/2] fs, ceph filesystem refcount conversions

Started byElena Reshetova <elena.reshetova@intel.com>
First post2017-03-03 13:40 +0100
Last post2017-03-03 19:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/2] fs, ceph filesystem refcount conversions Elena Reshetova <elena.reshetova@intel.com> - 2017-03-03 13:40 +0100
    Re: [PATCH 0/2] fs, ceph filesystem refcount conversions Ilya Dryomov <idryomov@gmail.com> - 2017-03-03 19:40 +0100

#1591907 — [PATCH 0/2] fs, ceph filesystem refcount conversions

FromElena Reshetova <elena.reshetova@intel.com>
Date2017-03-03 13:40 +0100
Subject[PATCH 0/2] fs, ceph filesystem refcount conversions
Message-ID<tgRxv-7rN-17@gated-at.bofh.it>
Now when new refcount_t type and API are finally merged
(see include/linux/refcount.h), the following
patches convert various refcounters in the ceph filesystem from atomic_t
to refcount_t. By doing this we prevent intentional or accidental
underflows or overflows that can led to use-after-free vulnerabilities.

The below patches are fully independent and can be cherry-picked separately.
Since we convert all kernel subsystems in the same fashion, resulting
in about 300 patches, we have to group them for sending at least in some
fashion to be manageable. Please excuse the long cc list.

Not runtime tested, since I am not sure how to do it for ceph.
However changes are pretty trivial in this case.

Elena Reshetova (2):
  fs, ceph: convert ceph_mds_session.s_ref from atomic_t to refcount_t
  fs, ceph: convert ceph_cap_snap.nref from atomic_t to refcount_t

 fs/ceph/caps.c       |  4 ++--
 fs/ceph/mds_client.c | 18 +++++++++---------
 fs/ceph/mds_client.h |  5 +++--
 fs/ceph/snap.c       |  2 +-
 fs/ceph/super.h      |  5 +++--
 5 files changed, 18 insertions(+), 16 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]


#1592197

FromIlya Dryomov <idryomov@gmail.com>
Date2017-03-03 19:40 +0100
Message-ID<th0hr-58n-5@gated-at.bofh.it>
In reply to#1591907
On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova
<elena.reshetova@intel.com> wrote:
> Now when new refcount_t type and API are finally merged
> (see include/linux/refcount.h), the following
> patches convert various refcounters in the ceph filesystem from atomic_t
> to refcount_t. By doing this we prevent intentional or accidental
> underflows or overflows that can led to use-after-free vulnerabilities.
>
> The below patches are fully independent and can be cherry-picked separately.
> Since we convert all kernel subsystems in the same fashion, resulting
> in about 300 patches, we have to group them for sending at least in some
> fashion to be manageable. Please excuse the long cc list.
>
> Not runtime tested, since I am not sure how to do it for ceph.
> However changes are pretty trivial in this case.
>
> Elena Reshetova (2):
>   fs, ceph: convert ceph_mds_session.s_ref from atomic_t to refcount_t
>   fs, ceph: convert ceph_cap_snap.nref from atomic_t to refcount_t
>
>  fs/ceph/caps.c       |  4 ++--
>  fs/ceph/mds_client.c | 18 +++++++++---------
>  fs/ceph/mds_client.h |  5 +++--
>  fs/ceph/snap.c       |  2 +-
>  fs/ceph/super.h      |  5 +++--
>  5 files changed, 18 insertions(+), 16 deletions(-)

I'll pull these into testing.

Thanks,

                Ilya

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web