Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590429 > unrolled thread
| Started by | David Sterba <dsterba@suse.cz> |
|---|---|
| First post | 2017-03-01 16:50 +0100 |
| Last post | 2017-03-02 20:50 +0100 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h David Sterba <dsterba@suse.cz> - 2017-03-01 16:50 +0100
Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h David Sterba <dsterba@suse.cz> - 2017-03-02 14:40 +0100
Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-02 15:00 +0100
Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h David Sterba <dsterba@suse.cz> - 2017-03-02 20:10 +0100
[PATCH] MAINTAINERS: add btrfs file entries "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-02 20:50 +0100
| From | David Sterba <dsterba@suse.cz> |
|---|---|
| Date | 2017-03-01 16:50 +0100 |
| Subject | Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h |
| Message-ID | <tgeFQ-55d-19@gated-at.bofh.it> |
On Wed, Mar 01, 2017 at 02:12:50AM +0300, Dmitry V. Levin wrote: > btrfs_err_str function is not called from anywhere and is replicated > in the userspace headers for btrfs-progs. > > It's removal also fixes the following linux/btrfs.h userspace > compilation error: > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str': > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function) > return NULL; > > Suggested-by: Jeff Mahoney <jeffm@suse.com> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > Reviewed-by: David Sterba <dsterba@suse.com> > --- > v3: the patch seems to be lost, resending with updated list of addressees Indeed, I can't find how or where it got lost, sorry. Added to 4.11 again.
[toc] | [next] | [standalone]
| From | David Sterba <dsterba@suse.cz> |
|---|---|
| Date | 2017-03-02 14:40 +0100 |
| Message-ID | <tgz7A-2SA-3@gated-at.bofh.it> |
| In reply to | #1590429 |
On Wed, Mar 01, 2017 at 03:54:35PM +0100, David Sterba wrote: > On Wed, Mar 01, 2017 at 02:12:50AM +0300, Dmitry V. Levin wrote: > > btrfs_err_str function is not called from anywhere and is replicated > > in the userspace headers for btrfs-progs. > > > > It's removal also fixes the following linux/btrfs.h userspace > > compilation error: > > > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str': > > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function) > > return NULL; > > > > Suggested-by: Jeff Mahoney <jeffm@suse.com> > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > > Reviewed-by: David Sterba <dsterba@suse.com> > > --- > > v3: the patch seems to be lost, resending with updated list of addressees > > Indeed, I can't find how or where it got lost, sorry. Added to 4.11 > again. So it's because you did not CC linux-btrfs@ , I have the mails in my inbox but haven't found it in the other folder while picking patches.
[toc] | [prev] | [next] | [standalone]
| From | "Dmitry V. Levin" <ldv@altlinux.org> |
|---|---|
| Date | 2017-03-02 15:00 +0100 |
| Subject | Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h |
| Message-ID | <tgzqW-2ZE-33@gated-at.bofh.it> |
| In reply to | #1591076 |
On Thu, Mar 02, 2017 at 12:42:12PM +0100, David Sterba wrote: > On Wed, Mar 01, 2017 at 03:54:35PM +0100, David Sterba wrote: > > On Wed, Mar 01, 2017 at 02:12:50AM +0300, Dmitry V. Levin wrote: > > > btrfs_err_str function is not called from anywhere and is replicated > > > in the userspace headers for btrfs-progs. > > > > > > It's removal also fixes the following linux/btrfs.h userspace > > > compilation error: > > > > > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str': > > > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function) > > > return NULL; > > > > > > Suggested-by: Jeff Mahoney <jeffm@suse.com> > > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > > > Reviewed-by: David Sterba <dsterba@suse.com> > > > --- > > > v3: the patch seems to be lost, resending with updated list of addressees > > > > Indeed, I can't find how or where it got lost, sorry. Added to 4.11 > > again. > > So it's because you did not CC linux-btrfs@ , I have the mails in my > inbox but haven't found it in the other folder while picking patches. Thanks, I though so when Cc'ed linux-btrfs@ the last time. Consider updating MAINTAINERS file so that scripts/get_maintainer.pl would be able to print the right addressees for btrfs header files: diff --git a/MAINTAINERS b/MAINTAINERS index 0001835..04a758f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2905,4 +2905,6 @@ S: Maintained F: Documentation/filesystems/btrfs.txt F: fs/btrfs/ +F: include/linux/btrfs* +F: include/uapi/linux/btrfs* BTTV VIDEO4LINUX DRIVER -- ldv
[toc] | [prev] | [next] | [standalone]
| From | David Sterba <dsterba@suse.cz> |
|---|---|
| Date | 2017-03-02 20:10 +0100 |
| Message-ID | <tgEgW-6Ib-13@gated-at.bofh.it> |
| In reply to | #1591102 |
On Thu, Mar 02, 2017 at 04:01:17PM +0300, Dmitry V. Levin wrote: > On Thu, Mar 02, 2017 at 12:42:12PM +0100, David Sterba wrote: > > On Wed, Mar 01, 2017 at 03:54:35PM +0100, David Sterba wrote: > > > On Wed, Mar 01, 2017 at 02:12:50AM +0300, Dmitry V. Levin wrote: > > > > btrfs_err_str function is not called from anywhere and is replicated > > > > in the userspace headers for btrfs-progs. > > > > > > > > It's removal also fixes the following linux/btrfs.h userspace > > > > compilation error: > > > > > > > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str': > > > > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function) > > > > return NULL; > > > > > > > > Suggested-by: Jeff Mahoney <jeffm@suse.com> > > > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > > > > Reviewed-by: David Sterba <dsterba@suse.com> > > > > --- > > > > v3: the patch seems to be lost, resending with updated list of addressees > > > > > > Indeed, I can't find how or where it got lost, sorry. Added to 4.11 > > > again. > > > > So it's because you did not CC linux-btrfs@ , I have the mails in my > > inbox but haven't found it in the other folder while picking patches. > > Thanks, I though so when Cc'ed linux-btrfs@ the last time. > > Consider updating MAINTAINERS file so that scripts/get_maintainer.pl > would be able to print the right addressees for btrfs header files: Good idea. > diff --git a/MAINTAINERS b/MAINTAINERS > index 0001835..04a758f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2905,4 +2905,6 @@ S: Maintained > F: Documentation/filesystems/btrfs.txt > F: fs/btrfs/ > +F: include/linux/btrfs* > +F: include/uapi/linux/btrfs* > > BTTV VIDEO4LINUX DRIVER Please send a proper patch and add Acked-by: David Sterba <dsterba@suse.com>
[toc] | [prev] | [next] | [standalone]
| From | "Dmitry V. Levin" <ldv@altlinux.org> |
|---|---|
| Date | 2017-03-02 20:50 +0100 |
| Subject | [PATCH] MAINTAINERS: add btrfs file entries |
| Message-ID | <tgETE-6XA-5@gated-at.bofh.it> |
| In reply to | #1591401 |
Add file entries for btrfs header files. Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> Acked-by: David Sterba <dsterba@suse.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0001835..04a758f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2904,6 +2904,8 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git S: Maintained F: Documentation/filesystems/btrfs.txt F: fs/btrfs/ +F: include/linux/btrfs* +F: include/uapi/linux/btrfs* BTTV VIDEO4LINUX DRIVER M: Mauro Carvalho Chehab <mchehab@s-opensource.com> -- ldv
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web