Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590676 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-03-02 00:00 +0100 |
| Last post | 2017-03-06 14:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] staging/vc04_services: initialize cache line size properly Arnd Bergmann <arnd@arndb.de> - 2017-03-02 00:00 +0100
Re: [PATCH 1/2] staging/vc04_services: initialize cache line size properly Michael Zoran <mzoran@crowfest.net> - 2017-03-02 03:00 +0100
Re: [PATCH 1/2] staging/vc04_services: initialize cache line size properly Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-06 14:00 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-03-02 00:00 +0100 |
| Subject | [PATCH 1/2] staging/vc04_services: initialize cache line size properly |
| Message-ID | <tglnX-1pB-11@gated-at.bofh.it> |
While debugging another problem I noticed that g_cache_line_size gets set
to sizeof(CACHE_LINE_SIZE), which is sizeof(int) or 4, while presumably
CACHE_LINE_SIZE (e.g. 32) was meant.
This initializes it the way it was meant.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
index 3aeffcb9c87e..b0e9eb6ff73f 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
@@ -78,7 +78,7 @@ struct vchiq_pagelist_info {
};
static void __iomem *g_regs;
-static unsigned int g_cache_line_size = sizeof(CACHE_LINE_SIZE);
+static unsigned int g_cache_line_size = CACHE_LINE_SIZE;
static unsigned int g_fragments_size;
static char *g_fragments_base;
static char *g_free_fragments;
--
2.9.0
[toc] | [next] | [standalone]
| From | Michael Zoran <mzoran@crowfest.net> |
|---|---|
| Date | 2017-03-02 03:00 +0100 |
| Subject | Re: [PATCH 1/2] staging/vc04_services: initialize cache line size properly |
| Message-ID | <tgoc9-3mW-1@gated-at.bofh.it> |
| In reply to | #1590676 |
Hi Arnd,
I submitted a change which is in Linux-next now that makes the whole
CACHE_LINE_SIZE macro meaningless. It now always reads the size from
the DT and errors out with -ENODEV if the property is missing.
I was going to submit a change to delete the macro completely, just
never got to it.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit
/drivers/staging/vc04_services/interface?id=6cf1bf636a067eb308cb3a8322b
9d6b1844a075d
On Wed, 2017-03-01 at 23:50 +0100, Arnd Bergmann wrote:
> While debugging another problem I noticed that g_cache_line_size gets
> set
> to sizeof(CACHE_LINE_SIZE), which is sizeof(int) or 4, while
> presumably
> CACHE_LINE_SIZE (e.g. 32) was meant.
>
> This initializes it the way it was meant.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c |
> 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> index 3aeffcb9c87e..b0e9eb6ff73f 100644
> ---
> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> +++
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> @@ -78,7 +78,7 @@ struct vchiq_pagelist_info {
> };
>
> static void __iomem *g_regs;
> -static unsigned int g_cache_line_size = sizeof(CACHE_LINE_SIZE);
> +static unsigned int g_cache_line_size = CACHE_LINE_SIZE;
> static unsigned int g_fragments_size;
> static char *g_fragments_base;
> static char *g_free_fragments;
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-06 14:00 +0100 |
| Subject | Re: [PATCH 1/2] staging/vc04_services: initialize cache line size properly |
| Message-ID | <ti0p5-8iJ-39@gated-at.bofh.it> |
| In reply to | #1590794 |
On Wed, Mar 01, 2017 at 05:59:38PM -0800, Michael Zoran wrote: > Hi Arnd, > > I submitted a change which is in Linux-next now that makes the whole > CACHE_LINE_SIZE macro meaningless. It now always reads the size from > the DT and errors out with -ENODEV if the property is missing. > > I was going to submit a change to delete the macro completely, just > never got to it. > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit > /drivers/staging/vc04_services/interface?id=6cf1bf636a067eb308cb3a8322b > 9d6b1844a075d This should be in 4.11-rc1. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web