Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1590744 > unrolled thread

[PATCHv2 03/14] arm64: Use set_memory.h header

Started byLaura Abbott <labbott@redhat.com>
First post2017-03-02 01:50 +0100
Last post2017-03-02 16:10 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCHv2 03/14] arm64: Use set_memory.h header Laura Abbott <labbott@redhat.com> - 2017-03-02 01:50 +0100
    Re: [PATCHv2 03/14] arm64: Use set_memory.h header Mark Rutland <mark.rutland@arm.com> - 2017-03-02 15:10 +0100
    Re: [PATCHv2 03/14] arm64: Use set_memory.h header Catalin Marinas <catalin.marinas@arm.com> - 2017-03-02 16:10 +0100

#1590744 — [PATCHv2 03/14] arm64: Use set_memory.h header

FromLaura Abbott <labbott@redhat.com>
Date2017-03-02 01:50 +0100
Subject[PATCHv2 03/14] arm64: Use set_memory.h header
Message-ID<tgn6q-2E1-13@gated-at.bofh.it>
The set_memory_* functions have moved to set_memory.h. Use that header
explicitly.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
 arch/arm64/mm/pageattr.c      | 1 +
 arch/arm64/net/bpf_jit_comp.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
index 8def55e..12ab86d 100644
--- a/arch/arm64/mm/pageattr.c
+++ b/arch/arm64/mm/pageattr.c
@@ -18,6 +18,7 @@
 
 #include <asm/pgtable.h>
 #include <asm/tlbflush.h>
+#include <asm/set_memory.h>
 
 struct page_change_data {
 	pgprot_t set_mask;
diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
index a785554..84e4a91 100644
--- a/arch/arm64/net/bpf_jit_comp.c
+++ b/arch/arm64/net/bpf_jit_comp.c
@@ -26,6 +26,7 @@
 
 #include <asm/byteorder.h>
 #include <asm/cacheflush.h>
+#include <asm/set_memory.h>
 #include <asm/debug-monitors.h>
 
 #include "bpf_jit.h"
-- 
2.7.4

[toc] | [next] | [standalone]


#1591112

FromMark Rutland <mark.rutland@arm.com>
Date2017-03-02 15:10 +0100
Message-ID<tgzAB-3lq-9@gated-at.bofh.it>
In reply to#1590744
On Wed, Mar 01, 2017 at 04:14:55PM -0800, Laura Abbott wrote:
> 
> The set_memory_* functions have moved to set_memory.h. Use that header
> explicitly.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
>  arch/arm64/mm/pageattr.c      | 1 +
>  arch/arm64/net/bpf_jit_comp.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 8def55e..12ab86d 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -18,6 +18,7 @@
>  
>  #include <asm/pgtable.h>
>  #include <asm/tlbflush.h>
> +#include <asm/set_memory.h>

Nit: alphabetical order, please.

>  
>  struct page_change_data {
>  	pgprot_t set_mask;
> diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
> index a785554..84e4a91 100644
> --- a/arch/arm64/net/bpf_jit_comp.c
> +++ b/arch/arm64/net/bpf_jit_comp.c
> @@ -26,6 +26,7 @@
>  
>  #include <asm/byteorder.h>
>  #include <asm/cacheflush.h>
> +#include <asm/set_memory.h>
>  #include <asm/debug-monitors.h>

Nit: likewise.

Otherwise, this looks fine to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

>  
>  #include "bpf_jit.h"
> -- 
> 2.7.4
> 

[toc] | [prev] | [next] | [standalone]


#1591177

FromCatalin Marinas <catalin.marinas@arm.com>
Date2017-03-02 16:10 +0100
Message-ID<tgAwG-3Yt-33@gated-at.bofh.it>
In reply to#1590744
On Wed, Mar 01, 2017 at 04:14:55PM -0800, Laura Abbott wrote:
> The set_memory_* functions have moved to set_memory.h. Use that header
> explicitly.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web