Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1590090 > unrolled thread

[PATCH] bpf: update the comment about the length of analysis

Started byGary Lin <glin@suse.com>
First post2017-03-01 09:30 +0100
Last post2017-03-02 01:50 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] bpf: update the comment about the length of analysis Gary Lin <glin@suse.com> - 2017-03-01 09:30 +0100
    Re: [PATCH] bpf: update the comment about the length of analysis Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2017-03-01 18:20 +0100
    Re: [PATCH] bpf: update the comment about the length of analysis David Miller <davem@davemloft.net> - 2017-03-02 01:50 +0100

#1590090 — [PATCH] bpf: update the comment about the length of analysis

FromGary Lin <glin@suse.com>
Date2017-03-01 09:30 +0100
Subject[PATCH] bpf: update the comment about the length of analysis
Message-ID<tg7O1-jL-1@gated-at.bofh.it>
Commit 07016151a446 ("bpf, verifier: further improve search
pruning") increased the limit of processed instructions from
32k to 64k, but the comment still mentioned the 32k limit.
This commit updates the comment to reflect the change.

Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Gary Lin <glin@suse.com>
---
 kernel/bpf/verifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index cdc43b899f28..0960f65c6da7 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -33,7 +33,7 @@
  * - out of bounds or malformed jumps
  * The second pass is all possible path descent from the 1st insn.
  * Since it's analyzing all pathes through the program, the length of the
- * analysis is limited to 32k insn, which may be hit even if total number of
+ * analysis is limited to 64k insn, which may be hit even if total number of
  * insn is less then 4K, but there are too many branches that change stack/regs.
  * Number of 'branches to be analyzed' is limited to 1k
  *
-- 
2.12.0

[toc] | [next] | [standalone]


#1590522

FromAlexei Starovoitov <alexei.starovoitov@gmail.com>
Date2017-03-01 18:20 +0100
Message-ID<tgg4W-6cR-7@gated-at.bofh.it>
In reply to#1590090
On Wed, Mar 01, 2017 at 04:25:51PM +0800, Gary Lin wrote:
> Commit 07016151a446 ("bpf, verifier: further improve search
> pruning") increased the limit of processed instructions from
> 32k to 64k, but the comment still mentioned the 32k limit.
> This commit updates the comment to reflect the change.
> 
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Gary Lin <glin@suse.com>

Acked-by: Alexei Starovoitov <ast@kernel.org>

[toc] | [prev] | [next] | [standalone]


#1590740

FromDavid Miller <davem@davemloft.net>
Date2017-03-02 01:50 +0100
Message-ID<tgn6p-2E1-3@gated-at.bofh.it>
In reply to#1590090
From: Gary Lin <glin@suse.com>
Date: Wed,  1 Mar 2017 16:25:51 +0800

> Commit 07016151a446 ("bpf, verifier: further improve search
> pruning") increased the limit of processed instructions from
> 32k to 64k, but the comment still mentioned the 32k limit.
> This commit updates the comment to reflect the change.
> 
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Gary Lin <glin@suse.com>

Applied, thanks.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web