Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590695 > unrolled thread
| Started by | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| First post | 2017-03-02 00:40 +0100 |
| Last post | 2017-03-09 01:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] rtc: omap: remove incorrect __exit markups Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-02 00:40 +0100
Re: [PATCH] rtc: omap: remove incorrect __exit markups Sebastian Reichel <sre@kernel.org> - 2017-03-02 01:30 +0100
Re: [PATCH] rtc: omap: remove incorrect __exit markups Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-09 01:40 +0100
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-03-02 00:40 +0100 |
| Subject | [PATCH] rtc: omap: remove incorrect __exit markups |
| Message-ID | <tgm0F-1V5-5@gated-at.bofh.it> |
Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe(), which specifically disables sysfs bind/unbind
attributes.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/rtc/rtc-omap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 51e52446eacb..fa856d9c5e23 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc-omap.c
@@ -844,7 +844,7 @@ static int omap_rtc_probe(struct platform_device *pdev)
return ret;
}
-static int __exit omap_rtc_remove(struct platform_device *pdev)
+static int omap_rtc_remove(struct platform_device *pdev)
{
struct omap_rtc *rtc = platform_get_drvdata(pdev);
u8 reg;
@@ -964,7 +964,7 @@ static void omap_rtc_shutdown(struct platform_device *pdev)
static struct platform_driver omap_rtc_driver = {
.probe = omap_rtc_probe,
- .remove = __exit_p(omap_rtc_remove),
+ .remove = omap_rtc_remove,
.shutdown = omap_rtc_shutdown,
.driver = {
.name = "omap_rtc",
--
2.12.0.rc1.440.g5b76565f74-goog
--
Dmitry
[toc] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2017-03-02 01:30 +0100 |
| Message-ID | <tgmN5-2vO-33@gated-at.bofh.it> |
| In reply to | #1590695 |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On Wed, Mar 01, 2017 at 03:33:23PM -0800, Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, devices can be unbound from the
> driver via sysfs, so we should not be using __exit annotations on
> remove() methods. The only exception is drivers registered with
> platform_driver_probe(), which specifically disables sysfs bind/unbind
> attributes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
> ---
> drivers/rtc/rtc-omap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 51e52446eacb..fa856d9c5e23 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -844,7 +844,7 @@ static int omap_rtc_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int __exit omap_rtc_remove(struct platform_device *pdev)
> +static int omap_rtc_remove(struct platform_device *pdev)
> {
> struct omap_rtc *rtc = platform_get_drvdata(pdev);
> u8 reg;
> @@ -964,7 +964,7 @@ static void omap_rtc_shutdown(struct platform_device *pdev)
>
> static struct platform_driver omap_rtc_driver = {
> .probe = omap_rtc_probe,
> - .remove = __exit_p(omap_rtc_remove),
> + .remove = omap_rtc_remove,
> .shutdown = omap_rtc_shutdown,
> .driver = {
> .name = "omap_rtc",
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-03-09 01:40 +0100 |
| Message-ID | <tiUhA-5JZ-13@gated-at.bofh.it> |
| In reply to | #1590695 |
On 01/03/2017 at 15:33:23 -0800, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe(), which specifically disables sysfs bind/unbind > attributes. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/rtc/rtc-omap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web