Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590209 > unrolled thread
| Started by | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| First post | 2017-03-01 11:40 +0100 |
| Last post | 2017-03-02 02:30 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-03-01 11:40 +0100
Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings Daniel Glöckner <daniel-gl@gmx.net> - 2017-03-01 23:10 +0100
Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings Alan Cox <alan@linux.intel.com> - 2017-03-01 23:30 +0100
Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings Fengguang Wu <fengguang.wu@intel.com> - 2017-03-02 02:30 +0100
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2017-03-01 11:40 +0100 |
| Subject | [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings |
| Message-ID | <tg9PS-1LH-67@gated-at.bofh.it> |
drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox <alan@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
imx.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/staging/media/atomisp/i2c/imx/imx.c
+++ b/drivers/staging/media/atomisp/i2c/imx/imx.c
@@ -2483,7 +2483,6 @@ MODULE_DEVICE_TABLE(i2c, imx_ids);
static struct i2c_driver imx_driver = {
.driver = {
- .owner = THIS_MODULE,
.name = IMX_DRIVER,
},
.probe = imx_probe,
[toc] | [next] | [standalone]
| From | Daniel Glöckner <daniel-gl@gmx.net> |
|---|---|
| Date | 2017-03-01 23:10 +0100 |
| Subject | Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings |
| Message-ID | <tgkBA-12L-9@gated-at.bofh.it> |
| In reply to | #1590209 |
On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote: > drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it. > > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > CC: Alan Cox <alan@linux.intel.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> May I ask which repository this patch is based on? Does Intel finally attempt to upstream the atomisp driver? Best regards, Daniel
[toc] | [prev] | [next] | [standalone]
| From | Alan Cox <alan@linux.intel.com> |
|---|---|
| Date | 2017-03-01 23:30 +0100 |
| Subject | Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings |
| Message-ID | <tgkUW-1b6-17@gated-at.bofh.it> |
| In reply to | #1590651 |
On Wed, 2017-03-01 at 22:58 +0100, Daniel Glöckner wrote: > On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote: > > > > drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to > > set .owner here. The core will do it. > > > > Remove .owner field if calls are used which set it automatically > > > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > > > CC: Alan Cox <alan@linux.intel.com> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > > May I ask which repository this patch is based on? It's a major clean up from internal code. For various reasons the previous history of the code can't be exposed (the internal repository we have contains code that can't go out of Intel for example). > Does Intel finally attempt to upstream the atomisp driver? That's the goal for the ISP 2 driver (Baytrail/T and later Cherrytrail). I can't speak for longer term plans with ISP 3 and later devices which currently don't have upstream drivers. There are some bits of support in ISP2 for some of the odder phone platforms as well but I don't have a way to test them or think anyone cares so plan to drop those. Alan
[toc] | [prev] | [next] | [standalone]
| From | Fengguang Wu <fengguang.wu@intel.com> |
|---|---|
| Date | 2017-03-02 02:30 +0100 |
| Message-ID | <tgnJ8-38l-17@gated-at.bofh.it> |
| In reply to | #1590651 |
On Wed, Mar 01, 2017 at 10:58:59PM +0100, Daniel Glöckner wrote:
>On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
>> drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner here. The core will do it.
>>
>> Remove .owner field if calls are used which set it automatically
>>
>> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>>
>> CC: Alan Cox <alan@linux.intel.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
>
>May I ask which repository this patch is based on?
The email is replying to this one, which shows Greg's staging tree.
Date: Wed, 1 Mar 2017 18:30:16 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: Alan Cox <alan@linux.intel.com>
Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, kbuild-all@01.org
Subject: [kbuild-all] [staging:staging-testing 209/209] drivers/staging/media/atomisp/i2c/gc2235.c:37:41: fatal error:
linux/atomisp_gmin_platform.h: No such file or directory
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head: 628b2b91d50c74e2475a11a0db5978d9a36d2026
commit: 628b2b91d50c74e2475a11a0db5978d9a36d2026 [209/209] staging/atomisp: Add support for the Intel IPU v2
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout 628b2b91d50c74e2475a11a0db5978d9a36d2026
# save the attached .config to linux build tree
make ARCH=i386
>Does Intel finally attempt to upstream the atomisp driver?
It looks so.
Thanks,
Fengguang
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web