Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584410 > unrolled thread

[PATCH v2 4/4] acpi: Move the verification of duplicate proc_id from booting time to hot-plug time

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 4/4] acpi: Move the verification of duplicate proc_id from booting time to hot-plug time Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-02-20 09:50 +0100
    Re: [PATCH v2 4/4] acpi: Move the verification of duplicate proc_id  from booting time to hot-plug time Thomas Gleixner <tglx@linutronix.de> - 2017-03-01 12:30 +0100
      Re: [PATCH v2 4/4] acpi: Move the verification of duplicate proc_id  from booting time to hot-plug time Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-02 09:40 +0100

#1584410 — [PATCH v2 4/4] acpi: Move the verification of duplicate proc_id from booting time to hot-plug time

After we revert the the mapping of "cpuid <-> nodeid" fixed at the
booting time. and do it at the hot-plug time. we should also do the
verification of duplicate proc_id at the time.

The patch rename the verfication function and move it to
drivers/acpi::acpi_processor_get_info.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
 drivers/acpi/acpi_processor.c | 13 ++++++++++---
 include/linux/acpi.h          |  2 +-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index eb500e1..2483383 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -280,6 +280,13 @@ static int acpi_processor_get_info(struct acpi_device *device)
 		pr->acpi_id = value;
 	}
 
+	if(duplicate_processor_id(pr->acpi_id)) {
+		dev_err(&device->dev,
+			"Failed to get unique processor _UID (0x%x)\n",
+			pr->acpi_id);
+		return -ENODEV;
+	}
+
 	pr->phys_id = acpi_get_phys_id(pr->handle, device_declaration,
 					pr->acpi_id);
 	if (invalid_phys_cpuid(pr->phys_id))
@@ -580,7 +587,7 @@ static struct acpi_scan_handler processor_container_handler = {
 static int nr_unique_ids __initdata;
 
 /* The number of the duplicate processor IDs */
-static int nr_duplicate_ids __initdata;
+static int nr_duplicate_ids;
 
 /* Used to store the unique processor IDs */
 static int unique_processor_ids[] __initdata = {
@@ -588,7 +595,7 @@ static int unique_processor_ids[] __initdata = {
 };
 
 /* Used to store the duplicate processor IDs */
-static int duplicate_processor_ids[] __initdata = {
+static int duplicate_processor_ids[] = {
 	[0 ... NR_CPUS - 1] = -1,
 };
 
@@ -672,7 +679,7 @@ void __init acpi_processor_check_duplicates(void)
 						NULL, NULL);
 }
 
-bool __init acpi_processor_validate_proc_id(int proc_id)
+bool duplicate_processor_id(int proc_id)
 {
 	int i;
 
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index d180cbd..b692a70 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -287,7 +287,7 @@ static inline bool invalid_phys_cpuid(phys_cpuid_t phys_id)
 }
 
 /* Validate the processor object's proc_id */
-bool acpi_processor_validate_proc_id(int proc_id);
+bool duplicate_processor_id(int proc_id);
 
 #ifdef CONFIG_ACPI_HOTPLUG_CPU
 /* Arch dependent functions for cpu hotplug support */
-- 
2.5.5

[toc] | [next] | [standalone]

#1590269 — Re: [PATCH v2 4/4] acpi: Move the verification of duplicate proc_id from booting time to hot-plug time

On Mon, 20 Feb 2017, Dou Liyang wrote:

Please make your subject line short and a precise summary phrase, not an
overlong sentence.

> After we revert the the mapping of "cpuid <-> nodeid" fixed at the
> booting time. and do it at the hot-plug time. we should also do the
> verification of duplicate proc_id at the time.

The revert is completely irrelevant to this change, really. The reference
is just confusing.

> The patch rename the verfication function and move it to
> drivers/acpi::acpi_processor_get_info.

See previous mails ....

Let me give you another changelog example:

Subject: acpi/processor: Check for duplicate processor ids at hotplug time

  The check for duplicate processor ids happens at boot time based on the
  ACPI table contents, but the final sanity checks for a processor happen
  at hotplug time.

  At hotplug time, where the physical information is available, which might
  differ from the ACPI table information, a check for duplicate processor
  ids is missing.

  Add it to the hotplug checks and rename the function so it better
  reflects its purpose.

Hmm?

>  
> -bool __init acpi_processor_validate_proc_id(int proc_id)
> +bool duplicate_processor_id(int proc_id)

Please keep the acpi_ prefix. acpi_duplicate_processor_id().

Thanks,

	tglx

[toc] | [prev] | [next] | [standalone]

#1590911 — Re: [PATCH v2 4/4] acpi: Move the verification of duplicate proc_id from booting time to hot-plug time

Hi tglx,

At 03/01/2017 07:26 PM, Thomas Gleixner wrote:
> On Mon, 20 Feb 2017, Dou Liyang wrote:
>
> Please make your subject line short and a precise summary phrase, not an
> overlong sentence.
>
>> After we revert the the mapping of "cpuid <-> nodeid" fixed at the
>> booting time. and do it at the hot-plug time. we should also do the
>> verification of duplicate proc_id at the time.
>
> The revert is completely irrelevant to this change, really. The reference
> is just confusing.
>

Yes, Maybe I should split them like before.


>> The patch rename the verfication function and move it to
>> drivers/acpi::acpi_processor_get_info.
>
> See previous mails ....
>
> Let me give you another changelog example:
>

Thanks again.

> Subject: acpi/processor: Check for duplicate processor ids at hotplug time
>
>   The check for duplicate processor ids happens at boot time based on the
>   ACPI table contents, but the final sanity checks for a processor happen
>   at hotplug time.
>
>   At hotplug time, where the physical information is available, which might
>   differ from the ACPI table information, a check for duplicate processor
>   ids is missing.
>
>   Add it to the hotplug checks and rename the function so it better
>   reflects its purpose.
>
> Hmm?

Yes, thanks again. I learned a lot in that patchset.

>
>>
>> -bool __init acpi_processor_validate_proc_id(int proc_id)
>> +bool duplicate_processor_id(int proc_id)
>
> Please keep the acpi_ prefix. acpi_duplicate_processor_id().

OK, I will.

Thanks,

	Liyang.
>
> Thanks,
>
> 	tglx
>
>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web