Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1591091 > unrolled thread
| Started by | Jaejoong Kim <climbbb.kim@gmail.com> |
|---|---|
| First post | 2017-03-02 15:00 +0100 |
| Last post | 2017-03-03 08:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev Jaejoong Kim <climbbb.kim@gmail.com> - 2017-03-02 15:00 +0100
Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-03-02 15:20 +0100
Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev Kim Jaejoong <climbbb.kim@gmail.com> - 2017-03-03 08:10 +0100
| From | Jaejoong Kim <climbbb.kim@gmail.com> |
|---|---|
| Date | 2017-03-02 15:00 +0100 |
| Subject | [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev |
| Message-ID | <tgzqV-2ZE-13@gated-at.bofh.it> |
We need to store the minor number each drivers. In case of hidraw, it's
minor number stores in struct hidraw. But hiddev's minor is located in
struct hid_device.
So reallocates for hiddev's minor number.
Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
drivers/hid/usbhid/hiddev.c | 1 +
include/linux/hid.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 700145b..5c2c489 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -47,6 +47,7 @@
#define HIDDEV_BUFFER_SIZE 2048
struct hiddev {
+ int minor;
int exist;
int open;
struct mutex existancelock;
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 28f38e2b8..643c017 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -541,7 +541,6 @@ struct hid_device { /* device report descriptor */
struct list_head inputs; /* The list of inputs */
void *hiddev; /* The hiddev structure */
void *hidraw;
- int minor; /* Hiddev minor number */
int open; /* is the device open by anyone? */
char name[128]; /* Device name */
--
2.7.4
[toc] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2017-03-02 15:20 +0100 |
| Subject | Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev |
| Message-ID | <tgzKh-3oK-3@gated-at.bofh.it> |
| In reply to | #1591091 |
On Mar 02 2017 or thereabouts, Jaejoong Kim wrote:
> We need to store the minor number each drivers. In case of hidraw, it's
> minor number stores in struct hidraw. But hiddev's minor is located in
> struct hid_device.
>
> So reallocates for hiddev's minor number.
>
There is not a real need to have this one in a separate patch. Also, it
depends on the patch "[PATCH] HID: cp2112: use proper hidraw name with
minor number", so better include this cp2112 in this series (as I
mentioned in the cp2112 patch).
I'd say simply squash this patch with 2/2 and have the cp2112 as 1/2.
Cheers,
Benjamin
> Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
> ---
> drivers/hid/usbhid/hiddev.c | 1 +
> include/linux/hid.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 700145b..5c2c489 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -47,6 +47,7 @@
> #define HIDDEV_BUFFER_SIZE 2048
>
> struct hiddev {
> + int minor;
> int exist;
> int open;
> struct mutex existancelock;
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 28f38e2b8..643c017 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -541,7 +541,6 @@ struct hid_device { /* device report descriptor */
> struct list_head inputs; /* The list of inputs */
> void *hiddev; /* The hiddev structure */
> void *hidraw;
> - int minor; /* Hiddev minor number */
>
> int open; /* is the device open by anyone? */
> char name[128]; /* Device name */
> --
> 2.7.4
>
[toc] | [prev] | [next] | [standalone]
| From | Kim Jaejoong <climbbb.kim@gmail.com> |
|---|---|
| Date | 2017-03-03 08:10 +0100 |
| Subject | Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev |
| Message-ID | <tgPvH-5Zw-7@gated-at.bofh.it> |
| In reply to | #1591121 |
2017-03-02 23:10 GMT+09:00 Benjamin Tissoires <benjamin.tissoires@redhat.com>:
> On Mar 02 2017 or thereabouts, Jaejoong Kim wrote:
>> We need to store the minor number each drivers. In case of hidraw, it's
>> minor number stores in struct hidraw. But hiddev's minor is located in
>> struct hid_device.
>>
>> So reallocates for hiddev's minor number.
>>
>
> There is not a real need to have this one in a separate patch. Also, it
> depends on the patch "[PATCH] HID: cp2112: use proper hidraw name with
> minor number", so better include this cp2112 in this series (as I
> mentioned in the cp2112 patch).
>
> I'd say simply squash this patch with 2/2 and have the cp2112 as 1/2.
Ok. I will resend v2 patchset.
Thanks.
jaejoong
>
> Cheers,
> Benjamin
>
>> Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
>> ---
>> drivers/hid/usbhid/hiddev.c | 1 +
>> include/linux/hid.h | 1 -
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
>> index 700145b..5c2c489 100644
>> --- a/drivers/hid/usbhid/hiddev.c
>> +++ b/drivers/hid/usbhid/hiddev.c
>> @@ -47,6 +47,7 @@
>> #define HIDDEV_BUFFER_SIZE 2048
>>
>> struct hiddev {
>> + int minor;
>> int exist;
>> int open;
>> struct mutex existancelock;
>> diff --git a/include/linux/hid.h b/include/linux/hid.h
>> index 28f38e2b8..643c017 100644
>> --- a/include/linux/hid.h
>> +++ b/include/linux/hid.h
>> @@ -541,7 +541,6 @@ struct hid_device { /* device report descriptor */
>> struct list_head inputs; /* The list of inputs */
>> void *hiddev; /* The hiddev structure */
>> void *hidraw;
>> - int minor; /* Hiddev minor number */
>>
>> int open; /* is the device open by anyone? */
>> char name[128]; /* Device name */
>> --
>> 2.7.4
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web