Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1591658 > unrolled thread

[PATCH] staging: rtl8192u: fix spacing around if statements

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: rtl8192u: fix spacing around if statements Robin Krahl <robin.krahl@ireas.org> - 2017-03-03 04:50 +0100
    Re: [PATCH] staging: rtl8192u: fix spacing around if statements Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-09 18:30 +0100

#1591658 — [PATCH] staging: rtl8192u: fix spacing around if statements

Corrects the spacing around two if statements to fix these checkpatch.pl
errors:

ERROR: space required before the open brace '{'
ERROR: space prohibited after that open parenthesis '('

Signed-off-by: Robin Krahl <robin.krahl@ireas.org>
---
 drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index b631990b4969..b61ffa35579b 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -269,7 +269,7 @@ int write_nic_byte_E(struct net_device *dev, int indx, u8 data)
 				 indx | 0xfe00, 0, usbdata, 1, HZ / 2);
 	kfree(usbdata);
 
-	if (status < 0){
+	if (status < 0) {
 		netdev_err(dev, "write_nic_byte_E TimeOut! status: %d\n",
 			   status);
 		return status;
@@ -2519,7 +2519,7 @@ static int rtl8192_read_eeprom_info(struct net_device *dev)
 			for (i = 0; i < 3; i++) {
 				if (bLoad_From_EEPOM) {
 					ret = eprom_read(dev, (EEPROM_TxPwIndex_OFDM_24G + i) >> 1);
-					if ( ret < 0)
+					if (ret < 0)
 						return ret;
 					if (((EEPROM_TxPwIndex_OFDM_24G + i) % 2) == 0)
 						tmpValue = (u16)ret & 0x00ff;
-- 
2.12.0

[toc] | [next] | [standalone]

#1596232

On Thu, Mar 02, 2017 at 11:16:23PM +0100, Robin Krahl wrote:
> Corrects the spacing around two if statements to fix these checkpatch.pl
> errors:
> 
> ERROR: space required before the open brace '{'
> ERROR: space prohibited after that open parenthesis '('
> 
> Signed-off-by: Robin Krahl <robin.krahl@ireas.org>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Someone else did this same change right before you did, sorry :(

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web