Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1591252 > unrolled thread

[PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

Started byGeorgios Emmanouil <geo.emmnl@gmail.com>
First post2017-03-02 17:20 +0100
Last post2017-03-04 23:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement Georgios Emmanouil <geo.emmnl@gmail.com> - 2017-03-02 17:20 +0100
    Re: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement Julian Calaby <julian.calaby@gmail.com> - 2017-03-04 23:50 +0100

#1591252 — [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

FromGeorgios Emmanouil <geo.emmnl@gmail.com>
Date2017-03-02 17:20 +0100
Subject[PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement
Message-ID<tgBCq-4RH-7@gated-at.bofh.it>
Modified the 'if-else' statement to make it more readable.

Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
 drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 2eebc62..d82f0ff 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -867,15 +867,10 @@ static int wilc_mac_open(struct net_device *ndev)
 							 wilc_get_vif_idx(vif),
 							 wl->open_ifcs);
 			} else {
-				if (memcmp(wl->vif[i ^ 1]->bssid,
-					   wl->vif[i ^ 1]->src_addr, 6))
-					wilc_set_wfi_drv_handler(vif,
-							 wilc_get_vif_idx(vif),
-							 0);
+				if (memcmp(wl->vif[i ^ 1]->bssid, wl->vif[i ^ 1]->src_addr, 6))
+					wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 0);
 				else
-					wilc_set_wfi_drv_handler(vif,
-							 wilc_get_vif_idx(vif),
-							 1);
+					wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 1);
 			}
 			wilc_set_operation_mode(vif, vif->iftype);

--
2.1.4

[toc] | [next] | [standalone]


#1592626

FromJulian Calaby <julian.calaby@gmail.com>
Date2017-03-04 23:50 +0100
Message-ID<thqEV-7AQ-15@gated-at.bofh.it>
In reply to#1591252
Hi All,

On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>

Again, I'm dubious if this is needed or helpful, but

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

> ---
>  drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web