Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590817 > unrolled thread
| Started by | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| First post | 2017-03-02 04:20 +0100 |
| Last post | 2017-03-02 16:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: tracing: add #undef to fix compile error Steven Rostedt <rostedt@goodmis.org> - 2017-03-02 04:20 +0100
Re: tracing: add #undef to fix compile error Rik van Riel <riel@redhat.com> - 2017-03-02 16:00 +0100
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2017-03-02 04:20 +0100 |
| Subject | Re: tracing: add #undef to fix compile error |
| Message-ID | <tgprz-4z2-3@gated-at.bofh.it> |
On Wed, 28 Sep 2016 22:55:54 -0400 Rik van Riel <riel@redhat.com> wrote: > There are several trace include files that define TRACE_INCLUDE_FILE. > > Include several of them in the same .c file (as I currently have in > some code I am working on), and the compile will blow up with a > "warning: "TRACE_INCLUDE_FILE" redefined #define TRACE_INCLUDE_FILE syscalls" > > Every other include file in include/trace/events/ avoids that issue > by having a #undef TRACE_INCLUDE_FILE before the #define; syscalls.h > should have one, too. Cleaning out my INBOX, I stumbled over this patch. It looks like I missed it. I'm guessing this is still an issue? (Too lazy to actually look deeper, well just too tired at the moment). -- Steve > > Signed-off-by: Rik van Riel <riel@redhat.com> > --- > include/trace/events/syscalls.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/trace/events/syscalls.h b/include/trace/events/syscalls.h > index 14e49c798135..b35533b94277 100644 > --- a/include/trace/events/syscalls.h > +++ b/include/trace/events/syscalls.h > @@ -1,5 +1,6 @@ > #undef TRACE_SYSTEM > #define TRACE_SYSTEM raw_syscalls > +#undef TRACE_INCLUDE_FILE > #define TRACE_INCLUDE_FILE syscalls > > #if !defined(_TRACE_EVENTS_SYSCALLS_H) || defined(TRACE_HEADER_MULTI_READ)
[toc] | [next] | [standalone]
| From | Rik van Riel <riel@redhat.com> |
|---|---|
| Date | 2017-03-02 16:00 +0100 |
| Message-ID | <tgAn1-3FV-33@gated-at.bofh.it> |
| In reply to | #1590817 |
On Wed, 2017-03-01 at 22:11 -0500, Steven Rostedt wrote: > On Wed, 28 Sep 2016 22:55:54 -0400 > Rik van Riel <riel@redhat.com> wrote: > > > There are several trace include files that define > > TRACE_INCLUDE_FILE. > > > > Include several of them in the same .c file (as I currently have in > > some code I am working on), and the compile will blow up with a > > "warning: "TRACE_INCLUDE_FILE" redefined #define TRACE_INCLUDE_FILE > > syscalls" > > > > Every other include file in include/trace/events/ avoids that issue > > by having a #undef TRACE_INCLUDE_FILE before the #define; > > syscalls.h > > should have one, too. > > Cleaning out my INBOX, I stumbled over this patch. It looks like I > missed it. I'm guessing this is still an issue? (Too lazy to actually > look deeper, well just too tired at the moment). I believe it is :) > > Signed-off-by: Rik van Riel <riel@redhat.com> > > --- > > include/trace/events/syscalls.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/trace/events/syscalls.h > > b/include/trace/events/syscalls.h > > index 14e49c798135..b35533b94277 100644 > > --- a/include/trace/events/syscalls.h > > +++ b/include/trace/events/syscalls.h > > @@ -1,5 +1,6 @@ > > #undef TRACE_SYSTEM > > #define TRACE_SYSTEM raw_syscalls > > +#undef TRACE_INCLUDE_FILE > > #define TRACE_INCLUDE_FILE syscalls > > > > #if !defined(_TRACE_EVENTS_SYSCALLS_H) || > > defined(TRACE_HEADER_MULTI_READ) > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web