Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583597 > unrolled thread
| Started by | Andrew Banman <abanman@hpe.com> |
|---|---|
| First post | 2017-02-17 18:10 +0100 |
| Last post | 2017-03-01 11:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] x86/platform/uv/BAU: Remove initial write to swack register Andrew Banman <abanman@hpe.com> - 2017-02-17 18:10 +0100
[tip:x86/urgent] x86/platform/uv/BAU: Fix HUB errors by remove initial write to sw-ack register tip-bot for Andrew Banman <tipbot@zytor.com> - 2017-03-01 11:50 +0100
| From | Andrew Banman <abanman@hpe.com> |
|---|---|
| Date | 2017-02-17 18:10 +0100 |
| Subject | [PATCH] x86/platform/uv/BAU: Remove initial write to swack register |
| Message-ID | <tbUcG-76j-17@gated-at.bofh.it> |
Writing to the software acknowledge clear register when there are no pending messages causes a HUB error to assert. The original intent of this write was to clear the pending bits before start of operation, but this is an incorrect method and has been determined to be unnecessary. Signed-off-by: Andrew Banman <abanman@hpe.com> Acked-by: Mike Travis <mike.travis@hpe.com> --- arch/x86/platform/uv/tlb_uv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c index 766d4d3..f25982c 100644 --- a/arch/x86/platform/uv/tlb_uv.c +++ b/arch/x86/platform/uv/tlb_uv.c @@ -1847,7 +1847,6 @@ static void pq_init(int node, int pnode) ops.write_payload_first(pnode, first); ops.write_payload_last(pnode, last); - ops.write_g_sw_ack(pnode, 0xffffUL); /* in effect, all msg_type's are set to MSG_NOOP */ memset(pqp, 0, sizeof(struct bau_pq_entry) * DEST_Q_SIZE); -- 1.8.2.1
[toc] | [next] | [standalone]
| From | tip-bot for Andrew Banman <tipbot@zytor.com> |
|---|---|
| Date | 2017-03-01 11:50 +0100 |
| Subject | [tip:x86/urgent] x86/platform/uv/BAU: Fix HUB errors by remove initial write to sw-ack register |
| Message-ID | <tg9Zw-1Pu-13@gated-at.bofh.it> |
| In reply to | #1583597 |
Commit-ID: 1b17c6df852851b40c3c27c66b8fa2fd99cf25d8 Gitweb: http://git.kernel.org/tip/1b17c6df852851b40c3c27c66b8fa2fd99cf25d8 Author: Andrew Banman <abanman@hpe.com> AuthorDate: Fri, 17 Feb 2017 11:07:49 -0600 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 1 Mar 2017 10:28:20 +0100 x86/platform/uv/BAU: Fix HUB errors by remove initial write to sw-ack register Writing to the software acknowledge clear register when there are no pending messages causes a HUB error to assert. The original intent of this write was to clear the pending bits before start of operation, but this is an incorrect method and has been determined to be unnecessary. Signed-off-by: Andrew Banman <abanman@hpe.com> Acked-by: Mike Travis <mike.travis@hpe.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: akpm@linux-foundation.org Cc: rja@hpe.com Cc: sivanich@hpe.com Link: http://lkml.kernel.org/r/1487351269-181133-1-git-send-email-abanman@hpe.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/platform/uv/tlb_uv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c index 766d4d3..f25982c 100644 --- a/arch/x86/platform/uv/tlb_uv.c +++ b/arch/x86/platform/uv/tlb_uv.c @@ -1847,7 +1847,6 @@ static void pq_init(int node, int pnode) ops.write_payload_first(pnode, first); ops.write_payload_last(pnode, last); - ops.write_g_sw_ack(pnode, 0xffffUL); /* in effect, all msg_type's are set to MSG_NOOP */ memset(pqp, 0, sizeof(struct bau_pq_entry) * DEST_Q_SIZE);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web