Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589414 > unrolled thread
| Started by | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| First post | 2017-02-28 13:50 +0100 |
| Last post | 2017-03-01 08:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature Peter Zijlstra <peterz@infradead.org> - 2017-02-28 13:50 +0100
Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature Peter Zijlstra <peterz@infradead.org> - 2017-02-28 14:50 +0100
Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature Byungchul Park <byungchul.park@lge.com> - 2017-03-01 08:00 +0100
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2017-02-28 13:50 +0100 |
| Subject | Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature |
| Message-ID | <tfPo6-4t2-11@gated-at.bofh.it> |
On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > + /* > + * struct held_lock does not have an indicator whether in nmi. > + */ > + int nmi; Do we really need this? Lockdep doesn't really know about NMI context, so its weird to now partially introduce it.
[toc] | [next] | [standalone]
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2017-02-28 14:50 +0100 |
| Message-ID | <tfQka-56u-23@gated-at.bofh.it> |
| In reply to | #1589414 |
On Tue, Feb 28, 2017 at 01:45:07PM +0100, Peter Zijlstra wrote: > On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > > + /* > > + * struct held_lock does not have an indicator whether in nmi. > > + */ > > + int nmi; > > Do we really need this? Lockdep doesn't really know about NMI context, > so its weird to now partially introduce it. That is, see how nmi_enter() includes lockdep_off().
[toc] | [prev] | [next] | [standalone]
| From | Byungchul Park <byungchul.park@lge.com> |
|---|---|
| Date | 2017-03-01 08:00 +0100 |
| Message-ID | <tg6oW-7DX-11@gated-at.bofh.it> |
| In reply to | #1589472 |
On Tue, Feb 28, 2017 at 01:49:06PM +0100, Peter Zijlstra wrote: > On Tue, Feb 28, 2017 at 01:45:07PM +0100, Peter Zijlstra wrote: > > On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > > > + /* > > > + * struct held_lock does not have an indicator whether in nmi. > > > + */ > > > + int nmi; > > > > Do we really need this? Lockdep doesn't really know about NMI context, > > so its weird to now partially introduce it. > > That is, see how nmi_enter() includes lockdep_off(). Indeed. OK. I will fix it.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web