Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588595 > unrolled thread

[PATCH 1/2] f2fs: fix memory leak of write_io_dummy mempool during umount

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] f2fs: fix memory leak of write_io_dummy mempool during umount Chao Yu <yuchao0@huawei.com> - 2017-02-27 11:50 +0100
    [PATCH 2/2] f2fs: fix to enlarge size of write_io_dummy mempool Chao Yu <yuchao0@huawei.com> - 2017-02-27 11:50 +0100

#1588595 — [PATCH 1/2] f2fs: fix memory leak of write_io_dummy mempool during umount

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 751e1068db17..53305880c455 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -818,7 +818,7 @@ static void f2fs_put_super(struct super_block *sb)
 	kfree(sbi->raw_super);
 
 	destroy_device_list(sbi);
-
+	mempool_destroy(sbi->write_io_dummy);
 	destroy_percpu_info(sbi);
 	kfree(sbi);
 }
-- 
2.8.2.295.g3f1c1d0

[toc] | [next] | [standalone]

#1588599 — [PATCH 2/2] f2fs: fix to enlarge size of write_io_dummy mempool

It needs to double cache size of write_io_dummy mempool, otherwise we may
run out of cache in scenraio of Data/Node IOs were issued concurrently.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 53305880c455..7571eb297b21 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1929,7 +1929,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
 
 	if (F2FS_IO_SIZE(sbi) > 1) {
 		sbi->write_io_dummy =
-			mempool_create_page_pool(F2FS_IO_SIZE(sbi) - 1, 0);
+			mempool_create_page_pool(2 * (F2FS_IO_SIZE(sbi) - 1), 0);
 		if (!sbi->write_io_dummy)
 			goto free_options;
 	}
-- 
2.8.2.295.g3f1c1d0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web