Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1587498 > unrolled thread

[PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA

Started byGeert Uytterhoeven <geert@linux-m68k.org>
First post2017-02-24 11:30 +0100
Last post2017-02-27 11:50 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-24 11:30 +0100
    [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-24 11:30 +0100
      Re: [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA Herbert Xu <herbert@gondor.apana.org.au> - 2017-02-27 11:50 +0100
    Re: [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and  CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA Herbert Xu <herbert@gondor.apana.org.au> - 2017-02-27 11:50 +0100

#1587498 — [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2017-02-24 11:30 +0100
Subject[PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA
Message-ID<telip-7ez-9@gated-at.bofh.it>
If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/crypto/atmel-tdes.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/crypto/atmel-sha.ko] undefined!

Add dependencies on HAS_DMA to fix this.

Fixes: ceb4afb3086ab08f ("crypto: atmel - refine Kconfig dependencies")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/crypto/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 2cac445b02fde0f6..69f7fc0dc84dc3b9 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -445,6 +445,7 @@ config CRYPTO_DEV_ATMEL_AES
 
 config CRYPTO_DEV_ATMEL_TDES
 	tristate "Support for Atmel DES/TDES hw accelerator"
+	depends on HAS_DMA
 	depends on ARCH_AT91 || COMPILE_TEST
 	select CRYPTO_DES
 	select CRYPTO_BLKCIPHER
@@ -458,6 +459,7 @@ config CRYPTO_DEV_ATMEL_TDES
 
 config CRYPTO_DEV_ATMEL_SHA
 	tristate "Support for Atmel SHA hw accelerator"
+	depends on HAS_DMA
 	depends on ARCH_AT91 || COMPILE_TEST
 	select CRYPTO_HASH
 	help
-- 
2.7.4

[toc] | [next] | [standalone]

#1587500 — [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2017-02-24 11:30 +0100
Subject[PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA
Message-ID<teliq-7ez-21@gated-at.bofh.it>
In reply to#1587498
If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/crypto/mediatek/mtk-crypto.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Fixes: 7dee9f618790d0b7 ("crypto: mediatek - remove ARM dependencies")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 69f7fc0dc84dc3b9..a7ff6e5d0ba92cb7 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -571,6 +571,7 @@ config CRYPTO_DEV_ROCKCHIP
 
 config CRYPTO_DEV_MEDIATEK
 	tristate "MediaTek's EIP97 Cryptographic Engine driver"
+	depends on HAS_DMA
 	depends on (ARM && ARCH_MEDIATEK) || COMPILE_TEST
 	select CRYPTO_AES
 	select CRYPTO_AEAD
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1588598 — Re: [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2017-02-27 11:50 +0100
SubjectRe: [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA
Message-ID<tfr2p-4lJ-11@gated-at.bofh.it>
In reply to#1587500
On Fri, Feb 24, 2017 at 11:27:39AM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [drivers/crypto/mediatek/mtk-crypto.ko] undefined!
> 
> Add a dependency on HAS_DMA to fix this.
> 
> Fixes: 7dee9f618790d0b7 ("crypto: mediatek - remove ARM dependencies")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [next] | [standalone]

#1588597 — Re: [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2017-02-27 11:50 +0100
SubjectRe: [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA
Message-ID<tfr2p-4lJ-9@gated-at.bofh.it>
In reply to#1587498
On Fri, Feb 24, 2017 at 11:27:38AM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [drivers/crypto/atmel-tdes.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/crypto/atmel-sha.ko] undefined!
> 
> Add dependencies on HAS_DMA to fix this.
> 
> Fixes: ceb4afb3086ab08f ("crypto: atmel - refine Kconfig dependencies")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web