Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588403 > unrolled thread

[PATCH] powernv:idle: Fix bug due to labeling ambiguity in power_enter_stop

Back to article view | Back to linux.kernel

Contents

  [PATCH] powernv:idle: Fix bug due to labeling ambiguity in power_enter_stop "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-02-26 22:40 +0100
    Re: [PATCH] powernv:idle: Fix bug due to labeling ambiguity in  power_enter_stop Anton Blanchard <anton@samba.org> - 2017-02-27 01:40 +0100
      Re: [PATCH] powernv:idle: Fix bug due to labeling ambiguity in  power_enter_stop Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-02-27 08:30 +0100

#1588403 — [PATCH] powernv:idle: Fix bug due to labeling ambiguity in power_enter_stop

From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>

Commit 09206b600c76 ("powernv: Pass PSSCR value and mask to
power9_idle_stop") added additional code in power_enter_stop() to
distinguish between stop requests whose PSSCR had ESL=EC=1 from those
which did not. When ESL=EC=1, we do a forward-jump to a location
labelled by "1", which had the code to handle the ESL=EC=1 case.

Unforunately just a couple of instructions before this label, is the
macro IDLE_STATE_ENTER_SEQ() which also has a label "1" in its
expansion.

As a result, the current code can result in directly executing stop
instruction for deep stop requests with PSSCR ESL=EC=1, without saving
the hypervisor state.

Fix this BUG by labeling the location that handles ESL=EC=1 case with
a more descriptive label.

For a good measure, change the label in IDLE_STATE_ENTER_SEQ() macro
to an not-so commonly used value.

Fixes: 09206b600c76 ("powernv: Pass PSSCR value and mask to
power9_idle_stop")

Cc: Michael Neuling <mikey@neuling.org>
Cc: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
---
 arch/powerpc/include/asm/cpuidle.h | 4 ++--
 arch/powerpc/kernel/idle_book3s.S  | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/include/asm/cpuidle.h b/arch/powerpc/include/asm/cpuidle.h
index 31192d8..3989d94 100644
--- a/arch/powerpc/include/asm/cpuidle.h
+++ b/arch/powerpc/include/asm/cpuidle.h
@@ -85,8 +85,8 @@ static inline void report_invalid_psscr_val(u64 psscr_val, int err)
 	std	r0,0(r1);					\
 	ptesync;						\
 	ld	r0,0(r1);					\
-1:	cmpd	cr0,r0,r0;					\
-	bne	1b;						\
+236:	cmpd	cr0,r0,r0;					\
+	bne	236b;						\
 	IDLE_INST;						\
 
 #define	IDLE_STATE_ENTER_SEQ_NORET(IDLE_INST)			\
diff --git a/arch/powerpc/kernel/idle_book3s.S b/arch/powerpc/kernel/idle_book3s.S
index 9f6bce5..95889af 100644
--- a/arch/powerpc/kernel/idle_book3s.S
+++ b/arch/powerpc/kernel/idle_book3s.S
@@ -276,14 +276,16 @@ power_enter_stop:
  */
 	andis.   r4,r3,PSSCR_EC_ESL_MASK_SHIFTED
 	clrldi   r3,r3,60 /* r3 = Bits[60:63] = Requested Level (RL) */
-	bne	 1f
+	bne	 handle_esl_ec_set
 	IDLE_STATE_ENTER_SEQ(PPC_STOP)
 	li	r3,0  /* Since we didn't lose state, return 0 */
 	b 	pnv_wakeup_noloss
+
+handle_esl_ec_set:
 /*
  * Check if the requested state is a deep idle state.
  */
-1:	LOAD_REG_ADDRBASE(r5,pnv_first_deep_stop_state)
+	LOAD_REG_ADDRBASE(r5,pnv_first_deep_stop_state)
 	ld	r4,ADDROFF(pnv_first_deep_stop_state)(r5)
 	cmpd	r3,r4
 	bge	2f
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1588428 — Re: [PATCH] powernv:idle: Fix bug due to labeling ambiguity in power_enter_stop

Hi Gautham,

> +handle_esl_ec_set:

Unless we want to expose this to things like perf, we might want to
make it a local label (eg .Lxx)

Anton

[toc] | [prev] | [next] | [standalone]

#1588529 — Re: [PATCH] powernv:idle: Fix bug due to labeling ambiguity in power_enter_stop

Hi Anton,
On Mon, Feb 27, 2017 at 10:37:07AM +1100, Anton Blanchard wrote:
> Hi Gautham,
> 
> > +handle_esl_ec_set:
> 
> Unless we want to expose this to things like perf, we might want to
> make it a local label (eg .Lxx)

Sure. We don't want to expose this to perf at least as of now! Will
resend the patch with a local label.
> 
> Anton
>

--
Thanks and Regards
gautham.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web