Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589815 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-02-28 22:40 +0100 |
| Last post | 2017-03-07 21:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net/mlx5e: add IPV6 dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:40 +0100
Re: [PATCH] net/mlx5e: add IPV6 dependency David Miller <davem@davemloft.net> - 2017-03-07 21:30 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-02-28 22:40 +0100 |
| Subject | [PATCH] net/mlx5e: add IPV6 dependency |
| Message-ID | <tfXF1-1ys-27@gated-at.bofh.it> |
The ethernet support now calls directly into the ipv6 core code, which fails if IPV6 is a loadable module but mlx5 is built-in: drivers/net/ethernet/mellanox/mlx5/core/en_tc.o: In function `mlx5e_create_encap_header_ipv6': en_tc.c:(.text.mlx5e_create_encap_header_ipv6+0x110): undefined reference to `ip6_route_output_flags' This adds a dependency to ensure that MLX5_CORE_EN can only be built if we are able link the kernel successfully. The downside is that the ethernet option can be hidden. Alternatively we could make MLX5_CORE depend on "IPV6 || !IPV6", which would force MLX5_CORE to be a module when IPV6 is, including in configurations where we don't use the ethernet support at all. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig index ddb4ca4ff930..117170014e88 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig @@ -14,6 +14,7 @@ config MLX5_CORE config MLX5_CORE_EN bool "Mellanox Technologies ConnectX-4 Ethernet support" depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE + depends on IPV6=y || IPV6=n || MLX5_CORE=m imply PTP_1588_CLOCK default n ---help--- -- 2.9.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-03-07 21:30 +0100 |
| Message-ID | <titU6-4iQ-9@gated-at.bofh.it> |
| In reply to | #1589815 |
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 28 Feb 2017 22:12:04 +0100 > The ethernet support now calls directly into the ipv6 core code, which > fails if IPV6 is a loadable module but mlx5 is built-in: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.o: In function `mlx5e_create_encap_header_ipv6': > en_tc.c:(.text.mlx5e_create_encap_header_ipv6+0x110): undefined reference to `ip6_route_output_flags' > > This adds a dependency to ensure that MLX5_CORE_EN can only be built > if we are able link the kernel successfully. The downside is that the > ethernet option can be hidden. Alternatively we could make MLX5_CORE > depend on "IPV6 || !IPV6", which would force MLX5_CORE to be a module > when IPV6 is, including in configurations where we don't use the ethernet > support at all. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web